Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vcv-rack: add desktop item #111042

Closed
wants to merge 1 commit into from
Closed

vcv-rack: add desktop item #111042

wants to merge 1 commit into from

Conversation

ddelabru
Copy link
Contributor

Motivation for this change

VCV Rack is distributed for Linux platforms as a source or binary tarball with no desktop entry. Because it is a desktop application, I have created a desktop item for it here.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ddelabru
Copy link
Contributor Author

@Moredread, @nathyong, heads up

@ofborg ofborg bot requested review from Moredread and nathyong January 28, 2021 20:21
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111042 run on x86_64-linux 1

1 package built:
  • vcv-rack

Moredread
Moredread approved these changes Feb 11, 2021
View reviewed changes
Copy link
Contributor

@Moredread Moredread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't easily see the resulting Desktop Items as I'm using i3 as my wm, but the source of the changes looks good.

@doronbehar
Copy link
Contributor

@ddelabru this PR looks good, though there are merge conflicts now. Could you address them please? BTW, tip: To avoid such merge conflicts, using 1 item per list in the arguments of buildInputs and in the arguments at the beginning of the expression helps a lot.

SuperSandro2000
SuperSandro2000 reviewed Aug 9, 2021
View reviewed changes
pkgs/applications/audio/vcv-rack/default.nix
Comment on lines +44 to +54
desktopItems = [ (makeDesktopItem {
type = "Application";
name = pname;
desktopName = "VCV Rack";
genericName = "Eurorack simulator";
comment = "Create music by patching together virtual synthesizer modules";
exec = "Rack";
icon = "Rack";
categories = "AudioVideo;AudioVideoEditing;Audio;";
extraEntries = "Keywords=music;";
}) ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
desktopItems = [ (makeDesktopItem {
type = "Application";
name = pname;
desktopName = "VCV Rack";
genericName = "Eurorack simulator";
comment = "Create music by patching together virtual synthesizer modules";
exec = "Rack";
icon = "Rack";
categories = "AudioVideo;AudioVideoEditing;Audio;";
extraEntries = "Keywords=music;";
}) ];
desktopItems = [
(makeDesktopItem {
type = "Application";
name = pname;
desktopName = "VCV Rack";
genericName = "Eurorack simulator";
comment = "Create music by patching together virtual synthesizer modules";
exec = "Rack";
icon = "Rack";
categories = "AudioVideo;AudioVideoEditing;Audio;";
extraEntries = "Keywords=music;";
})
];

SuperSandro2000
SuperSandro2000 reviewed Aug 9, 2021
View reviewed changes
pkgs/applications/audio/vcv-rack/default.nix
Comment on lines +110 to +111
if [ ! -e icon_"$size"x"$size"x32.png ]
then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if [ ! -e icon_"$size"x"$size"x32.png ]
then
if [ ! -e icon_"$size"x"$size"x32.png ]; then

SuperSandro2000
SuperSandro2000 reviewed Aug 9, 2021
View reviewed changes
pkgs/applications/audio/vcv-rack/default.nix
install -Dm644 icon_"$size"x"$size"x32.png $out/share/icons/hicolor/"$size"x"$size"/apps/Rack.png
done;

copyDesktopItems
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
copyDesktopItems
runHook postInstall

Also please add the preHook.

@stale
Copy link

stale bot commented Apr 19, 2022

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 19, 2022
@doronbehar
Copy link
Contributor

Closing due to no response from OP.

@doronbehar doronbehar closed this Apr 19, 2022
@ddelabru ddelabru mentioned this pull request Jun 16, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@Moredread Moredread Moredread approved these changes

@nathyong nathyong Awaiting requested review from nathyong

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ddelabru @SuperSandro2000 @doronbehar @Moredread