Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

darwin.CF: fix sandboxed build #111057

Merged
merged 1 commit into from Jan 31, 2021
Merged

darwin.CF: fix sandboxed build #111057

merged 1 commit into from Jan 31, 2021

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Jan 28, 2021

Had to abandon the use of sourceRoot primarily because it prevents
stdenv from chmod'ing the ../configure into a writable file.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl
darwin.CF: fix sandboxed build
6849638 
Had to abandon the use of sourceRoot primarily because it prevents
stdenv from chmod'ing the ../configure into a writable file.
@veprbl veprbl added this to WIP in Staging via automation Jan 28, 2021
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jan 28, 2021
@veprbl veprbl moved this from WIP to Needs review in Staging Jan 28, 2021
r-burns
r-burns approved these changes Jan 29, 2021
View reviewed changes
Copy link
Contributor

@r-burns r-burns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built darwin.apple_sdk.frameworks.CoreFoundation

@veprbl veprbl merged commit 84b3d08 into NixOS:staging Jan 31, 2021
Staging automation moved this from Needs review to Done Jan 31, 2021
@veprbl veprbl deleted the pr/darwin_CF_fix_sandboxing branch January 31, 2021 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-burns r-burns r-burns approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@veprbl @r-burns