Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firejail: 0.9.64 -> 0.9.64.2 #111039

Merged
merged 1 commit into from Feb 2, 2021
Merged

firejail: 0.9.64 -> 0.9.64.2 #111039

merged 1 commit into from Feb 2, 2021

Conversation

0x4A6F
Copy link
Member

@0x4A6F 0x4A6F commented Jan 28, 2021

Motivation for this change

Upgrade to 0.9.64.2.

  • nixfmt/nixpkgs-fmt
  • use fetchFromGitHub

@7c6f434c are you okay with moving this to fetchFromGitHub?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from 7c6f434c January 28, 2021 19:55
@7c6f434c 7c6f434c merged commit e83ab2e into NixOS:master Feb 2, 2021
@7c6f434c
Copy link
Member

7c6f434c commented Feb 2, 2021

Not sure I am in favour but surely not actively against, so if you get around to apdating it and you think it is more convenient like that, let it be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@0x4A6F @7c6f434c