Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xed-editor: Init at 2.8.4 #111040

Merged
merged 1 commit into from Feb 23, 2021
Merged

xed-editor: Init at 2.8.4 #111040

merged 1 commit into from Feb 23, 2021

Conversation

tu-maurice
Copy link
Contributor

@tu-maurice tu-maurice commented Jan 28, 2021 •
edited

Motivation for this change

Closes #108817

Also requested in #109578 but this issue also requests more packages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tu-maurice tu-maurice marked this pull request as draft January 28, 2021 19:53
@tu-maurice tu-maurice marked this pull request as ready for review January 28, 2021 19:58
@tu-maurice
Copy link
Contributor Author

The package is just called xed upstream, but there's already another package called xed. I called it xed-editor everywhere, not sure if that's the right choice.

@tu-maurice
Copy link
Contributor Author

I could also put it into cinnamon.xed as it depends on cinnamon.xapps?

taku0
taku0 approved these changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@taku0 taku0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine.

@taku0 taku0 merged commit 8e1b819 into NixOS:master Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taku0 taku0 taku0 approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Xed Text Editor
2 participants
@tu-maurice @taku0