Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tailscale: 1.4.0 -> 1.4.1 #111062

Merged
merged 1 commit into from Jan 29, 2021
Merged

tailscale: 1.4.0 -> 1.4.1 #111062

merged 1 commit into from Jan 29, 2021

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Jan 28, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bbigras
Copy link
Contributor Author

bbigras commented Jan 28, 2021

/marvin opt-in
/status needs_reviewer

@fabaff
Copy link
Member

fabaff commented Jan 29, 2021

Result of nixpkgs-review pr 111062 run on x86_64-linux 1

1 package built:
  • tailscale

fabaff
fabaff approved these changes Jan 29, 2021
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

...ew/pr-111062]$ ./results/tailscale/bin/tailscale -h
USAGE
  tailscale subcommand [flags]
[...]

Looks good to me.

danderson
danderson approved these changes Jan 29, 2021
View reviewed changes
Copy link
Contributor

@danderson danderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

/status needs_merger

@bbigras
Copy link
Contributor Author

bbigras commented Jan 29, 2021

@lovesegfault can you help with the merge please?

@lovesegfault lovesegfault merged commit f6ecd95 into NixOS:master Jan 29, 2021
@lovesegfault
Copy link
Member

Yup!

@bbigras bbigras deleted the tailscale branch January 29, 2021 15:10
@bbigras
Copy link
Contributor Author

bbigras commented Jan 29, 2021

Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danderson danderson danderson approved these changes

@fabaff fabaff fabaff approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

@martinbaillie martinbaillie Awaiting requested review from martinbaillie

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bbigras @fabaff @lovesegfault @danderson