Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvmPackages_11.libclc: 2019-06-09 -> 11.0.1 #111065

Merged
merged 7 commits into from Jul 20, 2021
Merged

llvmPackages_11.libclc: 2019-06-09 -> 11.0.1 #111065

merged 7 commits into from Jul 20, 2021

Conversation

TilCreator
Copy link
Contributor

Motivation for this change

The last version update was over 1.5a ago

Things done

The src was changed from llvm/llvm-project to llvm-mirror/libclc (with new sourceRoot) and the rev was updated to llvmorg-11.0.1.
The llvm Project replaced configure.py script with cmake and that got implemented.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@TilCreator
Copy link
Contributor Author

libclc_fix_includepath and libclc_fix_includepath depend on this pr

@TilCreator @SuperSandro2000
libclc: Change name to pname
148815b 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@SuperSandro2000
Copy link
Member

@TilCreator please fix the merge conflict.

@TilCreator
Copy link
Contributor Author

Sry for taking so long, it should be done now.

@kvtb
Copy link
Contributor

kvtb commented Jul 13, 2021 •
edited

Should it be llvmPackages_11.libclc ?

@TilCreator
Copy link
Contributor Author

Idk, but sounds reasonable

@SuperSandro2000 SuperSandro2000 changed the title libclc: 2019-06-09 -> 11.0.1 llvmPackages_11.libclc: 2019-06-09 -> 11.0.1 Jul 20, 2021
@SuperSandro2000 SuperSandro2000 merged commit 8c9748c into NixOS:master Jul 20, 2021
@jljusten jljusten mentioned this pull request Aug 13, 2021
Closed
@davidak davidak mentioned this pull request Sep 19, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TilCreator @SuperSandro2000 @kvtb