Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.ImageExifTool: 12.00 -> 12.16 #111024

Merged
merged 1 commit into from Jan 29, 2021
Merged

perlPackages.ImageExifTool: 12.00 -> 12.16 #111024

merged 1 commit into from Jan 29, 2021

Conversation

dywedir
Copy link
Member

@dywedir dywedir commented Jan 28, 2021

Motivation for this change

https://exiftool.org/history.html#v12.16

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dywedir dywedir requested a review from stigtsp as a code owner January 28, 2021 16:57
@stigtsp
Copy link
Member

stigtsp commented Jan 28, 2021

@ofborg build perlPackages.ImageExiftool

stigtsp
stigtsp requested changes Jan 28, 2021
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename commit message/pr to perlPackages.ImageExifTool

@stigtsp
Copy link
Member

stigtsp commented Jan 28, 2021

@ofborg build perlPackages.ImageExifTool

@dywedir
Copy link
Member Author

dywedir commented Jan 28, 2021

Oh my!

@dywedir dywedir changed the title perlPackages.ImageExiftool: 12.00 -> 12.16 perlPackages.ImageExifTool: 12.00 -> 12.16 Jan 28, 2021
@stigtsp
Copy link
Member

stigtsp commented Jan 29, 2021

@ofborg build perlPackages.ImageExifTool

stigtsp
stigtsp approved these changes Jan 29, 2021
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 111024 run on x86_64-linux 1

12 packages built:
  • digikam
  • exiftool (perl532Packages.ImageExifTool)
  • fgallery
  • gcstar
  • hugin
  • megapixels
  • pdf-redact-tools
  • perl530Packages.ImageExifTool
  • rapid-photo-downloader
  • shutter
  • styx
  • timelapse-deflicker

@stigtsp stigtsp merged commit de9aef7 into NixOS:master Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stigtsp stigtsp stigtsp approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dywedir @stigtsp