Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.somajo: 2.1.1 -> 2.1.2 #111128

Merged
merged 2 commits into from Jan 29, 2021
Merged

python3Packages.somajo: 2.1.1 -> 2.1.2 #111128

merged 2 commits into from Jan 29, 2021

Conversation

danieldk
Copy link
Contributor

Motivation for this change

Changelog:

https://github.com/tsproisl/SoMaJo/releases/tag/v2.1.2

Result of nixpkgs-review run on x86_64-linux 1

3 packages built:
  • python37Packages.somajo
  • python38Packages.somajo
  • python39Packages.somajo
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff
Copy link
Member

fabaff commented Jan 29, 2021

Result of nixpkgs-review pr 111128 run on x86_64-linux 1

3 packages built:
  • python37Packages.somajo
  • python38Packages.somajo
  • python39Packages.somajo

fabaff
fabaff requested changes Jan 29, 2021
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update the license details? gpl3 is a legacy alias. The license seems to be gpl3Plus . Thanks

Otherwise looks good to me.

@danieldk
Copy link
Contributor Author

Could you please update the license details? gpl3 is a legacy alias. The license seems to be gpl3Plus . Thanks

Good catch. Tacked on another commit with the license update.

@danieldk danieldk requested a review from fabaff January 29, 2021 08:50
@danieldk danieldk merged commit 5fb5d02 into NixOS:master Jan 29, 2021
@danieldk danieldk deleted the somajo-2.1.2 branch January 29, 2021 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabaff fabaff fabaff approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danieldk @fabaff