Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ndi: 4.5.3 -> 4.6.0 #111048

Merged
merged 1 commit into from Feb 11, 2021
Merged

ndi: 4.5.3 -> 4.6.0 #111048

merged 1 commit into from Feb 11, 2021

Conversation

lambdadog
Copy link
Contributor

Motivation for this change

Needed update to match upstream source, as 4.6.0 is the version
received when following the instructions to download.

Caused obs-ndi build to fail in #111029.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

ndi: 4.5.3 -> 4.6.0
f064938 
Needed update to match upstream source, as 4.6.0 is the version
received when following the instructions to download.
@lambdadog lambdadog mentioned this pull request Jan 28, 2021
Merged
10 tasks
@tomberek
Copy link
Contributor

tomberek commented Jan 30, 2021 •
edited

Result of nixpkgs-review pr 111048 run on x86_64-linux 1

1 package failed to build:
  • obs-ndi
``` $ nix --experimental-features nix-command build --no-link --keep-going --option build-use-sandbox relaxed -f /home/tom/.cache/nixpkgs-review/pr-111048/build.nix error: --- Error --- nix-daemon builder for '/nix/store/gayzs8kzhml5bj0j658c19601dyj7nlh-InstallNDISDK_v4_Linux.tar.gz.drv' failed with exit code 1; last 10 log lines: 
https://ndi.tv/sdk/

Once you have downloaded the file, please use the following command and
re-run the installation:

$ nix-prefetch-url file://$PWD/InstallNDISDK_v4_Linux.tar.gz

error: --- Error ----------------------------------------------------------------------------------------- nix
path '/nix/store/zanmk2lpflf2agp2h1r0qcz369m6iwa8-InstallNDISDK_v4_Linux.tar.gz' is not valid

</details>

@lambdadog
Copy link
Contributor Author

@bbigras any chance you could take a look at this?

@bbigras
Copy link
Contributor

bbigras commented Feb 8, 2021

Result of nixpkgs-review pr 111048 run on x86_64-linux 1

1 package built:
  • obs-ndi

@lambdadog
Copy link
Contributor Author

@SuperSandro2000 Could you take a look and see if I could get this merged?

Longer it sits the more likely it needs updating again unfortunately.

@SuperSandro2000 SuperSandro2000 merged commit 4f96c43 into NixOS:master Feb 11, 2021
@lilyinstarlight lilyinstarlight mentioned this pull request Aug 5, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbigras bbigras bbigras approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lambdadog @tomberek @bbigras @SuperSandro2000