Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scala: Replace VM test with installCheckPhase #111023

Merged
merged 1 commit into from Feb 3, 2021
Merged

scala: Replace VM test with installCheckPhase #111023

merged 1 commit into from Feb 3, 2021

Conversation

NeQuissimus
Copy link
Member

Motivation for this change

Reduce testing time and solidify checks at build time.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@NeQuissimus NeQuissimus added the 6.topic: testing Tooling for automated testing of packages and modules label Jan 28, 2021
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111023 run on x86_64-linux 1

4 packages built:
  • scala (scala_2_13)
  • scala_2_10
  • scala_2_11
  • scala_2_12

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111023 run on x86_64-darwin 1

4 packages built:
  • scala (scala_2_13)
  • scala_2_10
  • scala_2_11
  • scala_2_12

@NeQuissimus NeQuissimus marked this pull request as ready for review January 28, 2021 23:40
@NeQuissimus NeQuissimus merged commit 0d3bf07 into NixOS:master Feb 3, 2021
@NeQuissimus NeQuissimus deleted the scala_check branch February 3, 2021 15:24
@AndersonTorres
Copy link
Member

I am a bit curious about this. The NixOS checkings are mandatory once they are created?

As far as I think, they are complementary to the ones made by the upstream projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 6.topic: testing Tooling for automated testing of packages and modules 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NeQuissimus @SuperSandro2000 @AndersonTorres