Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.chainer: 6.5.0 -> 7.7.0 #111021

Merged
merged 2 commits into from Jan 29, 2021
Merged

python3Packages.chainer: 6.5.0 -> 7.7.0 #111021

merged 2 commits into from Jan 29, 2021

Conversation

ishiy1993
Copy link
Contributor

@ishiy1993 ishiy1993 commented Jan 28, 2021 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from hyphon81 January 28, 2021 15:39
@ishiy1993
Copy link
Contributor Author 

2 packages marked as broken and skipped:
python37Packages.optuna python38Packages.optuna

3 packages built:
python37Packages.chainer python38Packages.chainer python39Packages.chainer

SuperSandro2000
SuperSandro2000 reviewed Jan 28, 2021
View reviewed changes
pkgs/development/python-modules/chainer/default.nix Outdated
@@ -35,7 +30,7 @@ buildPythonPackage rec {

# avoid gpu tests
checkPhase = ''
pytest tests/chainer_tests/utils_tests -k 'not gpu and not cupy'
pytest tests/chainer_tests/utils_tests -k 'not gpu and not cupy and not ideep'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use pytestCheckHook and disabledTests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fix it. c355637

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111021 run on x86_64-darwin 1

2 packages marked as broken and skipped:
  • python37Packages.optuna
  • python38Packages.optuna
3 packages built:
  • python37Packages.chainer
  • python38Packages.chainer
  • python39Packages.chainer

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111021 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • python37Packages.optuna
  • python38Packages.optuna
3 packages built:
  • python37Packages.chainer
  • python38Packages.chainer
  • python39Packages.chainer

@SuperSandro2000 SuperSandro2000 merged commit da8a3c3 into NixOS:master Jan 29, 2021
@ishiy1993 ishiy1993 deleted the fix-chainer branch January 29, 2021 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@hyphon81 hyphon81 Awaiting requested review from hyphon81

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ishiy1993 @SuperSandro2000 @Janik-Haag