Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.starlette: fix build #111079

Merged
merged 1 commit into from Feb 11, 2021
Merged

python3Packages.starlette: fix build #111079

merged 1 commit into from Feb 11, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Jan 29, 2021

Motivation for this change

Fix build failure caused by failing test (encode/starlette#1131).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff
Copy link
Member Author

fabaff commented Jan 29, 2021

Result of nixpkgs-review pr 111079 run on x86_64-linux 1

1 package marked as broken and skipped:
  • python39Packages.starlette
4 packages built:
  • python37Packages.fastapi
  • python37Packages.starlette
  • python38Packages.fastapi
  • python38Packages.starlette

@ofborg ofborg bot requested a review from wd15 January 29, 2021 00:36
@fabaff
Copy link
Member Author

fabaff commented Jan 29, 2021

This will need another round as Python 3.9 is failing.

@fabaff fabaff changed the title python3Packages.starlette: fix build WIP: python3Packages.starlette: fix build Jan 29, 2021
@fabaff fabaff mentioned this pull request Jan 30, 2021
Merged
10 tasks
@fabaff fabaff changed the title WIP: python3Packages.starlette: fix build python3Packages.starlette: fix build Feb 3, 2021
@mweinelt
Copy link
Member

mweinelt commented Feb 4, 2021

I'm already waiting for the uvloop release for 3.9 for a while, I don't think we should wait with this change until then.

@mweinelt mweinelt mentioned this pull request Feb 6, 2021
Closed
10 tasks
@mweinelt
Copy link
Member

@fabaff Can you please update this pull request?

@mweinelt mweinelt mentioned this pull request Feb 10, 2021
Merged
10 tasks
@fabaff
Copy link
Member Author

fabaff commented Feb 10, 2021

Result of nixpkgs-review pr 111079 run on x86_64-linux 1

1 package marked as broken and skipped:
  • python39Packages.starlette
4 packages built:
  • python37Packages.fastapi
  • python37Packages.starlette
  • python38Packages.fastapi
  • python38Packages.starlette

mweinelt
mweinelt reviewed Feb 10, 2021
View reviewed changes
pkgs/development/python-modules/starlette/default.nix
pytestFlagsArray = [ "--ignore=tests/test_graphql.py" ];

disabledTestFiles = [ "tests/test_graphql.py" ];
# https://github.com/encode/starlette/issues/1131
Copy link
Member

@mweinelt mweinelt Feb 10, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue was closed 10 days ago. Is the test working now? Can we fetch a patch?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the package to 0.14.2 and dropped the disable.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, this breaks fastapi because they still haven't gotten rid of UJSONResponse.

@mweinelt
Copy link
Member

@GrahamcOfBorg build python3Packages.fastapi

@mweinelt
Copy link
Member

@GrahamcOfBorg build python3Packages.fastapi

@mweinelt mweinelt merged commit b73500f into NixOS:master Feb 11, 2021
@fabaff fabaff deleted the bump-starlette branch February 11, 2021 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda left review comments

@mweinelt mweinelt mweinelt approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@wd15 wd15 Awaiting requested review from wd15

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fabaff @mweinelt @dotlambda