Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-cross: add ppc64le, ppc64le-musl #111106

Merged
merged 1 commit into from Jan 30, 2021
Merged

release-cross: add ppc64le, ppc64le-musl #111106

merged 1 commit into from Jan 30, 2021

Conversation

r-burns
Copy link
Contributor

@r-burns r-burns commented Jan 29, 2021

Our support for ppc64le is pretty good now.
Let's add these so it's easier to spot and rectify breakage.

The toolchains are already built for their bootstrap tools,
so this shouldn't put much build strain on hydra.

Tested hydra-eval-jobs pkgs/top-level/release-cross.nix -I nixpkgs=. locally.

cc @NixOS/exotic-platform-maintainers

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-burns
release-cross: add ppc64le, ppc64le-musl
0ef31a8 
Our support for ppc64le is pretty good now.
Let's add these so it's easier to spot and rectify breakage.

The toolchains are already built for their bootstrap tools,
so this shouldn't put much build strain on hydra.
@Ericson2314
Copy link
Member

The toolchains are already built for their bootstrap tools,
so this shouldn't put much build strain on hydra.

Makes sense to me, but I'm out of date on what things we are building these days so I will wait for someone more in-the-know to confirm.

@matthewbauer
Copy link
Member

Looks good!

We do have a number of failing jobs. It would be nice if someone could systematically go through them and either fix or disable them based on what's wrong:

https://hydra.nixos.org/jobset/nixpkgs/cross-trunk/latest-eval#tabs-still-fail

@matthewbauer matthewbauer merged commit 58d07b1 into NixOS:master Jan 30, 2021
@r-burns
Copy link
Contributor Author

r-burns commented Jan 30, 2021

I've been trying to go through and fix what I can - some have a fix in the works; others might be beyond saving. I'll open some PRs to disable the latter category.

@r-burns r-burns deleted the hydra-ppc64le-cross branch January 30, 2021 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314 Ericson2314 is a code owner

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@r-burns @Ericson2314 @matthewbauer