Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deja-dup: add dconf #111123

Merged
merged 1 commit into from Jan 29, 2021
Merged

deja-dup: add dconf #111123

merged 1 commit into from Jan 29, 2021

Conversation

lasers
Copy link
Contributor

@lasers lasers commented Jan 29, 2021 •
edited

Motivation for this change

Deja-dup needs dconf to manage user settings. Otherwise, Deja-dup does unwanted things.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lasers
deja-dup: add dconf
84698ba 
Deja-dup needs dconf to manage user settings.
@ofborg ofborg bot requested a review from jtojnar January 29, 2021 06:26
@lasers
Copy link
Contributor Author

lasers commented Jan 29, 2021

I'm not familiar with Nix. Do I need both dconf or just the first one?

@SuperSandro2000
Copy link
Member

Do I need both dconf or just the first one?

If you just add it to inputs it does not do anything.

@Mic92
Copy link
Member

Mic92 commented Jan 29, 2021

Looks good:

╰─ % nix-review pr 111123
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0 pull/111123/head:refs/nixpkgs-review/1
remote: Enumerating objects: 24, done.
remote: Counting objects: 100% (24/24), done.
remote: Compressing objects: 100% (8/8), done.
remote: Total 30 (delta 18), reused 21 (delta 16), pack-reused 6
Unpacking objects: 100% (30/30), 6.01 KiB | 279.00 KiB/s, done.
From https://github.com/NixOS/nixpkgs
   3666a66ee0e..be580db895a  master                -> refs/nixpkgs-review/0
 + f56fa9538dd...84698bab23d refs/pull/111123/head -> refs/nixpkgs-review/1  (forced update)
Auto packing the repository in background for optimum performance.
See "git help gc" for manual housekeeping.
$ git worktree add /home/joerg/.cache/nixpkgs-review/pr-111123/nixpkgs be580db895a17b079f2d5f040e345c78629c5f2f
Preparing worktree (detached HEAD be580db895a)
Updating files: 100% (24217/24217), done.
HEAD is now at be580db895a Merge pull request #111088 from r-ryantm/auto-update/ffuf
$ git merge --no-commit 84698bab23d02393ab24e38a1e3ddb3d9d952861
Automatic merge went well; stopped before committing as requested
$ nix --experimental-features nix-command build --no-link --keep-going --option build-use-sandbox relaxed -f /home/joerg/.cache/nixpkgs-review/pr-111123/build.nix

Link to currently reviewing PR:
https://github.com/NixOS/nixpkgs/pull/111123

1 package built:
deja-dup

$ nix-shell /home/joerg/.cache/nixpkgs-review/pr-111123/shell.nix

[nix-shell:~/.cache/nixpkgs-review/pr-111123]$ which deja-dup
/nix/store/fh6kfv0fjhbijms8hvcpihsf0zdy7xb3-deja-dup-42.6/bin/deja-dup

[nix-shell:~/.cache/nixpkgs-review/pr-111123]$ grep dconf /nix/store/fh6kfv0fjhbijms8hvcpihsf0zdy7xb3-deja-dup-42.6/bin/deja-dup
export GIO_EXTRA_MODULES='/nix/store/ff82al5hzs9lpdzgk8cjjzpxy6qhxx9h-dconf-0.38.0-lib/lib/gio/modules'${GIO_EXTRA_MODULES:+':'}$GIO_EXTRA_MODULES
export GIO_EXTRA_MODULES='/nix/store/ff82al5hzs9lpdzgk8cjjzpxy6qhxx9h-dconf-0.38.0-lib/lib/gio/modules'${GIO_EXTRA_MODULES:+':'}$GIO_EXTRA_MODULES

@Mic92 Mic92 merged commit dd9f73e into NixOS:master Jan 29, 2021
@lasers lasers deleted the deja-dup-dconf branch January 29, 2021 11:50
@jtojnar
Copy link
Contributor

jtojnar commented Jan 29, 2021

dconf is added automatically by wrapGAppsHook so this is no-op.

@lasers
Copy link
Contributor Author

lasers commented Jan 29, 2021

Before I installed dconf manually on KDE, deja-dup would try to make a backup repeatedly at random times instead of scheduled weekly because it didn't write down the new last backup date. Also, this is my first Nix contribution. Sorry if it's no-op.

@jtojnar
Copy link
Contributor

jtojnar commented Jan 29, 2021

Yes, you need a dconf daemon but adding dconf library to buildInputs will not enable the daemon. See https://nixos.org/manual/nixpkgs/stable/#ssec-gnome-settings or #42433 (comment).

@jtojnar
Copy link
Contributor

jtojnar commented Feb 2, 2021

Reverted in cb52887.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lasers @SuperSandro2000 @Mic92 @jtojnar @Janik-Haag