Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insync-v3: init at 3.2.4.40856 #107478

Merged
merged 1 commit into from Jan 29, 2021
Merged

insync-v3: init at 3.2.4.40856 #107478

merged 1 commit into from Jan 29, 2021

Conversation

benley
Copy link
Member

@benley benley commented Dec 23, 2020

Fixes #104515

Motivation for this change

Insync 3.0 is a full rewrite with a different feature set than the existing v1 derivation in nixpkgs. Some users need to stick with the old version, particularly those on headless/non-GUI systems. There is a headless version of v3, but that will need to be packaged separately.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

pkgs/applications/networking/insync/v3.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/insync/v3.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/insync/v3.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/insync/v3.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107478 run on x86_64-linux 1

1 package built:
  • insync-v3

@SuperSandro2000
Copy link
Member

@benley ping

@benley
Copy link
Member Author

benley commented Jan 18, 2021

Oops, thank you for the ping. I'll get back to this ASAP

@benley
Copy link
Member Author

benley commented Jan 26, 2021

Sorry this is still unfinished - I'm planning on working on it tonight.

@SuperSandro2000 SuperSandro2000 marked this pull request as draft January 26, 2021 19:18
@benley benley marked this pull request as ready for review January 28, 2021 01:58
Insync 3.0 is a full rewrite with a different feature set than the
existing v1 derivation in nixpkgs.  Some users need to stick with the
old version, particularly those on headless/non-GUI systems.  There is
a headless version of v3, but that will need to be packaged separately.
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107478 run on x86_64-linux 1

1 package built:
  • insync-v3

@SuperSandro2000 SuperSandro2000 merged commit 64e1dc5 into NixOS:master Jan 29, 2021
@benley benley deleted the insync-v3 branch January 29, 2021 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace insync-portable 1.x with insync-headless 3.x
2 participants