Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: ff937db1f64a
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: bfc1cee4bf01
Choose a head ref
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Jan 28, 2021

  1. chromium: Fix the version comparison in print_updates()

    I forgot that string comparison isn't enough because e.g.:
    >>> "89.0.4389.9" < "89.0.4389.23"
    False
    
    distutils.version.LooseVersion is undocumented but it works and is
    already available so why not use it:
    >>> LooseVersion("89.0.4389.9") < LooseVersion("89.0.4389.23")
    True
    primeos committed Jan 28, 2021
    Copy the full SHA
    863982d View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    bfc1cee View commit details
    Browse the repository at this point in the history