Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] electrum: 4.0.2 -> 4.0.9 #111026

Merged
merged 6 commits into from Jan 28, 2021
Merged

[20.09] electrum: 4.0.2 -> 4.0.9 #111026

merged 6 commits into from Jan 28, 2021

Conversation

doronbehar
Copy link
Contributor

Motivation for this change

Fix #99982 .

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@doronbehar doronbehar mentioned this pull request Jan 28, 2021
Closed
@ofborg ofborg bot requested review from ehmry, prusnak, joachifm and np January 28, 2021 17:32
@prusnak prusnak changed the title electrum: 4.0.2 -> 4.0.9 [20.09] electrum: 4.0.2 -> 4.0.9 Jan 28, 2021
@prusnak prusnak added the 8.has: port to stable A PR already has a backport to the stable release. label Jan 28, 2021
prusnak
prusnak requested changes Jan 28, 2021
View reviewed changes
Copy link
Member

@prusnak prusnak left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commits should have been cherry-picked with git cherry-pick -x to include the reference to the original commit (from master)

@prusnak @doronbehar
electrum: 4.0.2 -> 4.0.3
a700fcf 
(cherry picked from commit edecced)
@prusnak @doronbehar
electrum: 4.0.3 -> 4.0.4
a0ac70b 
(cherry picked from commit 24883ec)
@prusnak @doronbehar
electrum: 4.0.4 -> 4.0.5
65b3df4 
(cherry picked from commit e4c6feb)
@prusnak @doronbehar
electrum: 4.0.5 -> 4.0.6
3a7c8e9 
(cherry picked from commit 739e97c)
@prusnak @doronbehar
electrum: 4.0.6 -> 4.0.7
ad04fed 
this release also fixes compatibility with dnspython 2.x,
so we can drop the overrides

also cryptography is required instead of pycryptodomex
(which is required only for tests now) and ecdsa dependency
is dropped completely

(cherry picked from commit 16b38b0)
@prusnak @doronbehar
electrum: 4.0.7 -> 4.0.9
d684e25 
(cherry picked from commit d18e00e)
@prusnak prusnak linked an issue Jan 28, 2021 that may be closed by this pull request
[20.09] electrum: qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in "" #99982
Closed
@prusnak prusnak merged commit c43ef1f into NixOS:release-20.09 Jan 28, 2021
@doronbehar doronbehar deleted the pkg/electrum branch March 2, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehmry ehmry Awaiting requested review from ehmry

@joachifm joachifm Awaiting requested review from joachifm

@np np Awaiting requested review from np

@prusnak prusnak Awaiting requested review from prusnak

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[20.09] electrum: qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
2 participants
@doronbehar @prusnak