Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

obs-studio: 26.0.2 -> 26.1.2 #111029

Merged
merged 2 commits into from Jan 28, 2021
Merged

obs-studio: 26.0.2 -> 26.1.2 #111029

merged 2 commits into from Jan 28, 2021

Conversation

lambdadog
Copy link
Contributor

@lambdadog lambdadog commented Jan 28, 2021 •
edited

Motivation for this change

Bump version. Allows using the new Twitch "VOD Audio Channel".

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

obs-studio: 26.0.2 -> 26.1.2
4210061 
Bump version. Allows using the new Twitch "VOD Audio Channel".
@ofborg ofborg bot requested review from MP2E and jb55 January 28, 2021 18:16
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111029 run on x86_64-linux 1

1 package failed to build and are new build failure:
  • obs-ndi: log was empty
5 packages built:
  • obs-gstreamer
  • obs-move-transition
  • obs-studio
  • obs-v4l2sink
  • obs-wlrobs

@lambdadog @SuperSandro2000
Update pkgs/applications/video/obs-studio/default.nix
97a7c02 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@lambdadog lambdadog mentioned this pull request Jan 28, 2021
Merged
10 tasks
@lambdadog
Copy link
Contributor Author

obs-ndi builds after my changes in #111048, although I'm uncertain whether an automated nixpkgs-review will be able to confirm that seeing as the NDI SDK download is a manual process.

@SuperSandro2000 SuperSandro2000 merged commit aa2274a into NixOS:master Jan 28, 2021
@Munksgaard
Copy link
Contributor

@lambdadog Did you check that the browser plugin still works? I see that you removed the use of refs/tags/${version} as the rev, but I think that has the unfortunate effect of not pulling submodules, which in turn means that the browser plugin does not work.

@SuperSandro2000
Copy link
Member

According to the log it build and linked the browser plugin.

@Munksgaard
Copy link
Contributor

Okay, thank you for checking. I'm having (unrelated) problems with my local obs install, so I couldn't verify it myself.

aforemny pushed a commit to aforemny/nixpkgs that referenced this pull request Mar 4, 2021
@lambdadog @SuperSandro2000 @aforemny
obs-studio: 26.0.2 -> 26.1.2 (NixOS#111029)
dd8536a 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@MP2E MP2E Awaiting requested review from MP2E

@jb55 jb55 Awaiting requested review from jb55

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lambdadog @SuperSandro2000 @Munksgaard @Janik-Haag