Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/miniflux: don't depend on sudo #111030

Merged
merged 1 commit into from Mar 13, 2021
Merged

nixos/miniflux: don't depend on sudo #111030

merged 1 commit into from Mar 13, 2021

Conversation

cript0nauta
Copy link
Contributor

Motivation for this change

i disabled sudo in my server due to its recent vulnerability. After doing this, the miniflux service failed to start.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cript0nauta
nixos/miniflux: don't depend on sudo
dac07be 
The miniflux service should work when sudo is not available in the
system.
@iblech
Copy link
Contributor

iblech commented Jan 29, 2021

Thank you! With this pull request we are now using systemd's UID changing capabilities. Even without the sudo vulnerability, this appears much cleaner to me.

@aanderse
Copy link
Member

After this is merged and I rebase would either of you mind reviewing #108906?

@aanderse aanderse requested a review from talyz February 10, 2021 02:08
@aanderse
Copy link
Member

@talyz requesting you because you have written a similar service in the past for gitlab IIRC.

@aanderse
Copy link
Member

@GrahamcOfBorg test miniflux

@cript0nauta cript0nauta mentioned this pull request Feb 26, 2021
Closed
10 tasks
@aanderse aanderse merged commit 5a24206 into NixOS:master Mar 13, 2021
@aanderse
Copy link
Member

Thanks @cript0nauta!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talyz talyz Awaiting requested review from talyz

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cript0nauta @iblech @aanderse