Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gobgp: init at 2.23.0 #111083

Merged
merged 2 commits into from Jan 29, 2021
Merged

gobgp: init at 2.23.0 #111083

merged 2 commits into from Jan 29, 2021
+41 −0

Conversation

higebu
Copy link
Contributor

@higebu higebu commented Jan 29, 2021 •
edited

Motivation for this change

A CLI tool for GoBGP. GoBGP is an open source BGP implementation. https://github.com/osrg/gobgp
I will create a gobgpd package as a next step.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    • 15MB
    $ nix path-info -S $(which gobgp)
/nix/store/mbmrqik607diwsdls8i78fn8j4pjjsbr-gobgp-2.23.0           15041048
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit January 29, 2021 00:53
SuperSandro2000
SuperSandro2000 requested changes Jan 29, 2021
View reviewed changes
maintainers/maintainer-list.nix Outdated
@@ -10526,4 +10526,10 @@
github = "jbcrail";
githubId = 6038;
};
higebu = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put this into a separate commit with the message maintainers: add higebu and sort it alphabetically.

pkgs/tools/networking/gobgp/default.nix Outdated

buildFlagsArray = ''
-ldflags=
-s -extldflags '-static'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
-s -extldflags '-static'
-s -w -extldflags '-static'

@higebu
Copy link
Contributor Author

higebu commented Jan 29, 2021

@SuperSandro2000 Thank you for your review. I fixed your requests.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111083 run on x86_64-darwin 1

1 package built:
  • gobgp

@SuperSandro2000 SuperSandro2000 merged commit 94cafab into NixOS:master Jan 29, 2021
@higebu higebu mentioned this pull request Jan 30, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@higebu @SuperSandro2000 @Janik-Haag