Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo-limit: 0.0.4 -> 0.0.5 #111086

Merged
merged 1 commit into from Jan 29, 2021
Merged

cargo-limit: 0.0.4 -> 0.0.5 #111086

merged 1 commit into from Jan 29, 2021

Conversation

otavio
Copy link
Contributor

@otavio otavio commented Jan 29, 2021 •
edited

Motivation for this change

New upstream release and the possibility of drop a patch 馃憤馃徏

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@otavio
cargo-limit: 0.0.4 -> 0.0.5
9af0b2f 
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
danieldk
danieldk approved these changes Jan 29, 2021
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 111086 run on x86_64-linux 1

1 package built:
  • cargo-limit

LGTM, programs seem to work as expected.

@danieldk danieldk merged commit 33484a2 into NixOS:master Jan 29, 2021
@otavio otavio deleted the upgrade/cargo-limit branch February 2, 2021 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@otavio @danieldk