Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] nixUnstable: patch #4470 (ETag) (#111005) #111035

Merged
merged 1 commit into from Jan 29, 2021
Merged

[20.09] nixUnstable: patch #4470 (ETag) (#111005) #111035

merged 1 commit into from Jan 29, 2021

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jan 28, 2021

Co-authored-by: Jörg Thalheim Mic92@users.noreply.github.com
(cherry picked from commit 1d41739)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 mentioned this pull request Jan 28, 2021
Merged
10 tasks
@SuperSandro2000 SuperSandro2000 changed the title nixUnstable: patch #4470 (ETag) (#111005) [backport] [20.09] nixUnstable: patch #4470 (ETag) (#111005) Jan 28, 2021
@roberth @Mic92
nixUnstable: patch NixOS#4470 (ETag) (NixOS#111005)
c560b41 
Co-authored-by: Jörg Thalheim <Mic92@users.noreply.github.com>
(cherry picked from commit 1d41739)
@roberth
Copy link
Member

roberth commented Jan 29, 2021

Evaluates correctly, but ofborg hasn't started on the darwin build after many hours. The patch isn't os-specific, so I see no reason for it to fail. Probably best to merge anyway.

@roberth roberth merged commit 683c553 into NixOS:release-20.09 Jan 29, 2021
@Mic92
Copy link
Member Author

Mic92 commented Jan 29, 2021

Evaluates correctly, but ofborg hasn't started on the darwin build after many hours. The patch isn't os-specific, so I see no reason for it to fail. Probably best to merge anyway.

We don't have a darwin builder for quite a while.

@Mic92 Mic92 deleted the nix-backport branch January 29, 2021 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@roberth roberth roberth approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Mic92 @roberth @thomasjm @SuperSandro2000