Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sphinx-autobuild: init at 2020.9.1 #109565

Merged
merged 2 commits into from Jan 31, 2021
Merged

sphinx-autobuild: init at 2020.9.1 #109565

merged 2 commits into from Jan 31, 2021

Conversation

HolgerPeters
Copy link
Contributor

Addresses #109564

Motivation for this change

Package seems to be missing albeit useful.

Be mindful, this is my first contribution to nixpkgs. I build the package locally in my shell.nix setup but it isn't exactly straightforward for me to test my patch in nixpkgs for some reason. I tried to produce a diff that looks like other Python package definitions.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 requested changes Jan 17, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add an entry to python top level file.

@HolgerPeters
Copy link
Contributor Author

You need to add an entry to python top level file.

I added it to pkgs/top-level/python-packages.nix

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109565 run on x86_64-darwin 1

3 packages built:
  • python37Packages.sphinx-autobuild
  • python38Packages.sphinx-autobuild
  • python39Packages.sphinx-autobuild

SuperSandro2000
SuperSandro2000 requested changes Jan 17, 2021
View reviewed changes
maintainers/maintainer-list.nix Outdated Show resolved Hide resolved
SuperSandro2000
SuperSandro2000 approved these changes Jan 18, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other then that diff LGTM

maintainers/maintainer-list.nix Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109565 run on x86_64-linux 1

3 packages built:
  • python37Packages.sphinx-autobuild
  • python38Packages.sphinx-autobuild
  • python39Packages.sphinx-autobuild

@SuperSandro2000
Copy link
Member

Please do not add fixup commits. GitHub does not always resolve them correctly.

HolgerPeters and others added 2 commits January 30, 2021 12:25
@HolgerPeters
maintainers: add holgerpeters
ab69a35
@HolgerPeters @SuperSandro2000 @fabaff
sphinx-autobuild: init at 2020.9.1
f11000e 
Python command line tool for autobuilding sphinx documentations.

Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
Co-authored-by: Fabian Affolter <mail@fabian-affolter.ch>
@SuperSandro2000 SuperSandro2000 merged commit 51f74e3 into NixOS:master Jan 31, 2021
@abathur abathur mentioned this pull request Aug 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@fabaff fabaff fabaff requested changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@HolgerPeters @SuperSandro2000 @fabaff @Janik-Haag