Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rocksdb: 6.14.6 -> 6.15.4 #109633

Merged
merged 4 commits into from Jan 26, 2021
Merged

rocksdb: 6.14.6 -> 6.15.4 #109633

merged 4 commits into from Jan 26, 2021

Conversation

cpcloud
Copy link
Contributor

@cpcloud cpcloud commented Jan 17, 2021

Motivation for this change

The motivation for this change is to update the rocksdb package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from magenbluten and adevress January 17, 2021 14:06
@SuperSandro2000
Copy link
Member 

hash mismatch in fixed-output derivation '/nix/store/i1gr74ry8smxjmni9xka08mna3vnc2qn-source.drv':                                                                                            specified: sha256-MTpIF0Tmd5xGxi3H8dW++60y6qOYONxtlMHLo2MjxR4=                                                                                                                                 got:    sha256-a2zf+OvTN6csnVoEGn1EIgWi1Y27ghvOF9ncxZip1os=

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109633 run on x86_64-linux 1

5 packages built:
  • blockbook
  • haskellPackages.rocksdb-haskell-jprupp
  • rocksdb
  • rocksdb_lite
  • sortmerna

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109633 run on x86_64-darwin 1

1 package failed to build and are new build failure:
2 packages built:
  • blockbook
  • haskellPackages.rocksdb-haskell-jprupp

@cpcloud
Copy link
Contributor Author

cpcloud commented Jan 18, 2021

@SuperSandro2000 The darwin failure kind of looks like a C++ compiler version issue, but I don't have a mac around that I can use to debug.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 The darwin failure kind of looks like a C++ compiler version issue, but I don't have a mac around that I can use to debug.

Can you mark sortmerna broken on darwin?

SuperSandro2000
SuperSandro2000 approved these changes Jan 19, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

@cpcloud cpcloud changed the title rocksdb: 6.14.6 -> 6.15.2 rocksdb: 6.14.6 -> 6.15.4 Jan 26, 2021
@ofborg ofborg bot requested review from luispedro and removed request for magenbluten January 26, 2021 18:04
@lovesegfault lovesegfault merged commit fbaf922 into NixOS:master Jan 26, 2021
@cpcloud cpcloud deleted the update-rocksdb branch January 26, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@adevress adevress Awaiting requested review from adevress

@luispedro luispedro Awaiting requested review from luispedro

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cpcloud @SuperSandro2000 @lovesegfault