Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefox: limit disable-elf-hack to arm, x86{,_64} #109598

Merged
merged 1 commit into from Jan 17, 2021
Merged

firefox: limit disable-elf-hack to arm, x86{,_64} #109598

merged 1 commit into from Jan 17, 2021

Conversation

S-NA
Copy link
Contributor

@S-NA S-NA commented Jan 17, 2021

Motivation for this change

This is a follow up to #106617 which brought LTO support but broke the AArch64 Firefox builds.

cc @lovesegfault

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@S-NA
firefox: limit disable-elf-hack to arm, x86{,_64}
00b75b7 
This is a follow up to NixOS#106617 which brought LTO support but broke the
AArch64 Firefox builds.
@lovesegfault
Copy link
Member

Building this on AArch64.

@ofborg ofborg bot requested a review from edolstra January 17, 2021 03:46
@lovesegfault
Copy link
Member

Result of nixpkgs-review pr 109598 1

7 packages built:
  • icedtea_web (icedtea8_web)
  • firefox (firefox-wrapper ,firefoxWrapper)
  • firefox-esr (firefox-esr-wrapper)
  • firefox-esr-78-unwrapped
  • firefox-unwrapped
  • firefox-wayland
  • slimerjs

@lovesegfault lovesegfault merged commit 9fcf3e5 into NixOS:master Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@S-NA @lovesegfault