Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo-readme: init at 3.2.0 #109591

Merged
merged 2 commits into from Jan 17, 2021
Merged

cargo-readme: init at 3.2.0 #109591

merged 2 commits into from Jan 17, 2021

Conversation

baloo
Copy link
Member

@baloo baloo commented Jan 17, 2021

Motivation for this change

Adds cargo-readme to nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff
Copy link
Member

fabaff commented Jan 17, 2021

Result of nixpkgs-review pr 109591 run on x86_64-linux 1

1 package built:
  • cargo-readme

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109591 run on x86_64-darwin 1

1 package built:
  • cargo-readme

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109591 run on x86_64-linux 1

1 package built:
  • cargo-readme

@baloo
maintainers: add baloo
4b385fc 
Signed-off-by: Arthur Gautier <baloo@superbaloo.net>
@baloo baloo force-pushed the baloo/cargo-readme/initial branch 3 times, most recently from 0eb67ef to 21082a2 Compare January 17, 2021 16:52
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109591 run on x86_64-darwin 1

1 package failed to build and are new build failure:
  • cargo-readme: log was empty
these derivations will be built:
  /nix/store/1g35xl0vr1jbisswq323f22szl9ky1z6-060f2daaa2b2cf981bf490dc36bcc6527545ea03.patch.drv
  /nix/store/0cd3551xrkk6svmyqvx2zc61py4i0b2w-cargo-readme-3.2.0.drv
building '/nix/store/1g35xl0vr1jbisswq323f22szl9ky1z6-060f2daaa2b2cf981bf490dc36bcc6527545ea03.patch.drv'...

trying https://github.com/livioribeiro/cargo-readme/commit/060f2daaa2b2cf981bf490dc36bcc6527545ea03.patch
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   886  100   886    0     0   2009      0 --:--:-- --:--:-- --:--:--  2013
hash mismatch in fixed-output derivation '/nix/store/n0x966l8nm7p5z44px1qgkl4z1fmyljl-060f2daaa2b2cf981bf490dc36bcc6527545ea03.patch':
  wanted: sha256:114laqw68b7zpsh99skr66lam64ls6r6rqidp5z443i2i2353w75
  got:    sha256:1swzgwhm4iwsxi04dbg3bkxs68zfm65c5v4rzi0anfix6a0hhl62
cannot build derivation '/nix/store/0cd3551xrkk6svmyqvx2zc61py4i0b2w-cargo-readme-3.2.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/0cd3551xrkk6svmyqvx2zc61py4i0b2w-cargo-readme-3.2.0.drv' faile

@baloo
cargo-readme: init at 3.2.0
75658b3 
Signed-off-by: Arthur Gautier <baloo@superbaloo.net>
@SuperSandro2000 SuperSandro2000 merged commit 842e808 into NixOS:master Jan 17, 2021
@baloo baloo deleted the baloo/cargo-readme/initial branch January 18, 2021 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@fabaff fabaff fabaff requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@baloo @fabaff @SuperSandro2000