Skip to content

pijul: 1.0.0-alpha.31 -> 1.0.0-alpha.35 #109592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2021
Merged

pijul: 1.0.0-alpha.31 -> 1.0.0-alpha.35 #109592

merged 1 commit into from
Jan 17, 2021
+3 −3

Conversation

a12l
Copy link
Contributor

@a12l a12l commented Jan 17, 2021

Motivation for this change

Pijul is still in alpha, so every update makes improvements

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@a12l
pijul: 1.0.0-alpha.31 -> 1.0.0-alpha.35

Verified

This commit was signed with the committer’s verified signature.
SamirHafez Samir Hafez
GPG key ID: 95806A3539FE7066
Verified
Learn about vigilant mode
5b80984
cole-h
cole-h approved these changes Jan 17, 2021
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM. Once again, welcome to the club!

Result of nixpkgs-review pr 109592 run on x86_64-linux 1

1 package built:
  • pijul

@cole-h
Copy link
Member

cole-h commented Jan 17, 2021

@ofborg eval

@ofborg ofborg bot requested review from dywedir and FlorentBecker January 17, 2021 02:22
@SuperSandro2000 SuperSandro2000 merged commit e9f2663 into NixOS:master Jan 17, 2021
@a12l a12l deleted the update-pijul-alpha35 branch January 17, 2021 09:16
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h

@dywedir dywedir

@FlorentBecker FlorentBecker

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@a12l @cole-h @SuperSandro2000 @Janik-Haag