zoom-us: 5.4.53350.1027 -> 5.4.57862.0110 #109602
Merged
+90
−100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replacing zooms qt library has led to incompatibilities between qt versions used in Nix and zoom. The new approach just sets LD_LIBRARY_PATH. LD_LIBRARY_PATH is also used internally by zoom for its own vendored library. The package has been tested end-to-end in a meeting.
ofborg
bot
added
10.rebuild-darwin: 0
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/show-case-for-nix-ld-run-umodified-zoom/11004/3 |
|
Tested and working on sway. I can join a meeting and use all features I need. |
|
Result of 1 package built:
|
|
Do we need to backport this? |
|
Backport: #109612 |
hmenke
reviewed
Jan 17, 2021
| ] ++ lib.optional (pulseaudioSupport) libpulseaudio); | ||
|
|
||
| in stdenv.mkDerivation { | ||
| name = "zoom-${version}"; |
There was a problem hiding this comment.
Why did you change
{
pname = "zoom-us";
inherit version;
}to
{
name = "zoom-${version}";
}Just curious.
There was a problem hiding this comment.
This was a mistake. At some point I switched to fhsUserEnv where I had to strip the version number.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing zooms qt library has let to incompatibilities between
qt versions used in Nix and zoom. The new approach just sets
LD_LIBRARY_PATH. LD_LIBRARY_PATH is also used internally by zoom
for its own vendored library.
The package has been tested end-to-end in a meeting.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)