Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

victoriametrics: 1.42.0 -> 1.52.0 #109575

Merged
merged 1 commit into from Jan 17, 2021
Merged

victoriametrics: 1.42.0 -> 1.52.0 #109575

merged 1 commit into from Jan 17, 2021

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Jan 16, 2021 •
edited

Also move from buildGoPackage to buildGoModule.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli
victoriametrics: 1.42.0 -> 1.52.0
a0bc587 
Also move from buildGoPackage to buildGoModule.
@ofborg ofborg bot requested a review from kalbasit January 16, 2021 22:26
@zimbatm
Copy link
Member

zimbatm commented Jan 16, 2021

Result of nixpkgs-review pr 109575 run on x86_64-linux 1

1 package failed to build:
  • victoriametrics

@marsam marsam merged commit 132835f into NixOS:master Jan 17, 2021
@flokli flokli deleted the victoriametrics-1.52.0 branch January 22, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam approved these changes

@zimbatm zimbatm Awaiting requested review from zimbatm

@yorickvP yorickvP Awaiting requested review from yorickvP

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flokli @zimbatm @marsam