Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.hug: disable broken marshmallow tests #109615

Merged
merged 2 commits into from Jan 17, 2021
Merged

python3Packages.hug: disable broken marshmallow tests #109615

merged 2 commits into from Jan 17, 2021

Conversation

urbas
Copy link
Contributor

@urbas urbas commented Jan 17, 2021

Motivation for this change

This change fixes this build failure.

Things done

Built the package on NixOS aarch64 (in addition to x86-64 Linux).

Output of nix-shell -p nixpkgs-review --run "nixpkgs-review wip":

3 packages updated:
python3.7-hug python3.8-hug python3.9-hug

3 packages built:
python37Packages.hug python38Packages.hug python39Packages.hug
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109615 run on x86_64-linux 1

3 packages built:
  • python37Packages.hug
  • python38Packages.hug
  • python39Packages.hug

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109615 run on x86_64-darwin 1

3 packages failed to build and are new build failures:

@SuperSandro2000 SuperSandro2000 merged commit 52a24dc into NixOS:master Jan 17, 2021
@SuperSandro2000
Copy link
Member

Next time please do not add fixup commits because github does not fixup them correctly.

@urbas
Copy link
Contributor Author

urbas commented Jan 18, 2021

Next time please do not add fixup commits because github does not fixup them correctly.

Apologies for that. I added the fixup! prefix more to give an indication that I will rebase before the PR gets merged. I wasn't sure if the commit was good or not so I wanted to keep it separate (so it can be easily reviewed in isolation).

I will from now on force-push all follow-up PR changes into a single commit (squashed) unless told otherwise.

@urbas urbas deleted the python-hug-test-failures branch January 23, 2021 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@urbas @SuperSandro2000