Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smartmontools: 7.1 -> 7.2 and devicedb updated to latest #109566

Merged
merged 2 commits into from Jan 17, 2021
Merged

smartmontools: 7.1 -> 7.2 and devicedb updated to latest #109566

merged 2 commits into from Jan 17, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jan 16, 2021

Motivation for this change

Updating smarmontools from 7.1 to 7.2 and the devicedb to latest.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost
Copy link
Author

ghost commented Jan 16, 2021

Note that testing compilation of all pkgs that depend on this change is infeasible on my local machine due to the amount of packages involved.

@ofborg ofborg bot requested review from peti and Frostman January 16, 2021 20:57
peti
peti approved these changes Jan 17, 2021
View reviewed changes
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 109566 run on x86_64-darwin 1

3 packages marked as broken and skipped:
  • haskellPackages.libzfs
  • sanoid
  • smartmontools

@SuperSandro2000
Update pkgs/tools/system/smartmontools/default.nix
a239ba2 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@ghost
Copy link
Author

ghost commented Jan 17, 2021

Unfortunately I do not have a darwin system to test the darwin build, so I applied the suggested fix. Please re-test when it's convenient for you, thanks.

@ofborg ofborg bot requested a review from peti January 17, 2021 11:50
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109566 run on x86_64-linux 1

6 packages marked as broken and skipped:
  • linuxPackages_hardkernel_4_14.zfs
  • linuxPackages_hardkernel_4_14.zfsStable
  • linuxPackages_hardkernel_4_14.zfsUnstable
  • linuxPackages_hardkernel_latest.zfs
  • linuxPackages_hardkernel_latest.zfsStable
  • linuxPackages_hardkernel_latest.zfsUnstable
1 package blacklisted:
  • tests.nixos-functions.nixosTest-test
4 packages failed to build and are new build failures:
  • libvmi: log was empty
  • linuxPackages-libre.zfs: log was empty
  • (linuxPackages-libre.zfsStable: log was empty
  • ,linuxPackages-libre.zfsUnstable): log was empty
64 packages built:
  • collectd
  • collectd-data
  • docker-machine-kvm
  • docker-machine-kvm2
  • easysnap
  • gnome3.gnome-boxes
  • grub2 (grub2_full)
  • grub2_efi
  • grub2_pvgrub_image
  • grub2_xen
  • gsmartcontrol
  • haskellPackages.libvirt-hs
  • haskellPackages.libzfs
  • libguestfs
  • libvirt
  • libvirt-glib
  • libvirt_5_9_0
  • linuxPackages.zfs (linuxPackages.zfsStable ,linuxPackages.zfsUnstable ,linuxPackages_5_4.zfs ,linuxPackages_5_4.zfsStable ,linuxPackages_5_4.zfsUnstable)
  • linuxPackages_4_14.zfs (linuxPackages_4_14.zfsStable ,linuxPackages_4_14.zfsUnstable)
  • linuxPackages_4_19.zfs (linuxPackages_4_19.zfsStable ,linuxPackages_4_19.zfsUnstable)
  • linuxPackages_4_4.zfs (linuxPackages_4_4.zfsStable ,linuxPackages_4_4.zfsUnstable)
  • linuxPackages_4_9.zfs (linuxPackages_4_9.zfsStable ,linuxPackages_4_9.zfsUnstable)
  • linuxPackages_5_10.zfs (linuxPackages_5_10.zfsStable ,linuxPackages_5_10.zfsUnstable ,linuxPackages_latest.zfs ,linuxPackages_latest.zfsStable ,linuxPackages_latest.zfsUnstable)
  • linuxPackages_5_9.zfs (linuxPackages_5_9.zfsStable ,linuxPackages_5_9.zfsUnstable)
  • linuxPackages_hardened.zfs (linuxPackages_hardened.zfsStable ,linuxPackages_hardened.zfsUnstable)
  • linuxPackages_latest-libre.zfs (linuxPackages_latest-libre.zfsStable ,linuxPackages_latest-libre.zfsUnstable)
  • linuxPackages_latest_hardened.zfs (linuxPackages_latest_hardened.zfsStable ,linuxPackages_latest_hardened.zfsUnstable)
  • linuxPackages_latest_xen_dom0.zfs (linuxPackages_latest_xen_dom0.zfsStable ,linuxPackages_latest_xen_dom0.zfsUnstable)
  • linuxPackages_latest_xen_dom0_hardened.zfs (linuxPackages_latest_xen_dom0_hardened.zfsStable ,linuxPackages_latest_xen_dom0_hardened.zfsUnstable)
  • linuxPackages_lqx.zfs (linuxPackages_lqx.zfsStable ,linuxPackages_lqx.zfsUnstable)
  • linuxPackages_testing_bcachefs.zfs (linuxPackages_testing_bcachefs.zfsStable ,linuxPackages_testing_bcachefs.zfsUnstable)
  • linuxPackages_xen_dom0.zfs (linuxPackages_xen_dom0.zfsStable ,linuxPackages_xen_dom0.zfsUnstable)
  • linuxPackages_xen_dom0_hardened.zfs (linuxPackages_xen_dom0_hardened.zfsStable ,linuxPackages_xen_dom0_hardened.zfsUnstable)
  • linuxPackages_zen.zfs (linuxPackages_zen.zfsStable ,linuxPackages_zen.zfsUnstable)
  • minikube
  • minishift
  • nixops
  • nixopsUnstable
  • nixops_1_6_1
  • os-prober
  • perl530Packages.SysVirt
  • perl532Packages.SysVirt
  • python37Packages.guestfs
  • python37Packages.libvirt
  • python38Packages.guestfs
  • python38Packages.libvirt
  • python39Packages.guestfs
  • python39Packages.libvirt
  • rubyPackages.ruby-libvirt (rubyPackages_2_6.ruby-libvirt)
  • rubyPackages_2_5.ruby-libvirt
  • rubyPackages_2_7.ruby-libvirt
  • sanoid
  • smartmontools
  • terraform-full
  • terraform-providers.libvirt
  • tlp
  • vagrant
  • virt-manager
  • virt-manager-qt
  • virt-top
  • virt-viewer
  • virtlyst
  • zfs (zfsStable ,zfsUnstable)
  • zfstools

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

libvirt:

A substituteInPlace with an unused --replace got detected:

substituteStream(): WARNING: pattern 'ON_BOOT=start' doesn't match anything in file '/nix/store/pw61hmq46092jibra4bs4q0w36ik9b70-libvirt-6.8.0/libexec/libvirt-guests.sh'
substituteStream(): WARNING: pattern 'ON_SHUTDOWN=suspend' doesn't match anything in file '/nix/store/pw61hmq46092jibra4bs4q0w36ik9b70-libvirt-6.8.0/libexec/libvirt-guests.sh'

Please check the offending substituteInPlace for typos or changes in source.

os-prober:

A substituteInPlace with an unused --replace got detected:

substituteStream(): WARNING: pattern '/usr/lib/linux-boot-probes/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/bin/os-prober'
substituteStream(): WARNING: pattern '/usr/lib/os-prober/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/bin/os-prober'
substituteStream(): WARNING: pattern '/usr/lib/os-probes/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/bin/linux-boot-prober'
substituteStream(): WARNING: pattern '/usr/lib/os-prober/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/bin/linux-boot-prober'
substituteStream(): WARNING: pattern '/usr/share/os-prober/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/share/common.sh'
substituteStream(): WARNING: pattern '/usr/lib/os-probes/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/share/common.sh'
substituteStream(): WARNING: pattern '/usr/lib/linux-boot-probes/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/share/common.sh'
substituteStream(): WARNING: pattern '/usr/lib/os-probes/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/os-probes/mounted/30utility'
substituteStream(): WARNING: pattern '/usr/lib/linux-boot-probes/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/os-probes/mounted/30utility'
substituteStream(): WARNING: pattern '/usr/lib/os-prober/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/os-probes/mounted/30utility'
substituteStream(): WARNING: pattern '/usr/lib/linux-boot-probes/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/os-probes/mounted/05efi'
substituteStream(): WARNING: pattern '/usr/lib/os-prober/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/os-probes/mounted/05efi'
substituteStream(): WARNING: pattern '/usr/lib/os-probes/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/os-probes/mounted/80minix'
substituteStream(): WARNING: pattern '/usr/lib/linux-boot-probes/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/os-probes/mounted/80minix'
substituteStream(): WARNING: pattern '/usr/lib/os-prober/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/os-probes/mounted/80minix'
substituteStream(): WARNING: pattern '/usr/lib/os-probes/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/os-probes/mounted/90linux-distro'
substituteStream(): WARNING: pattern '/usr/lib/linux-boot-probes/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/os-probes/mounted/90linux-distro'
substituteStream(): WARNING: pattern '/usr/lib/os-prober/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/os-probes/mounted/90linux-distro'
substituteStream(): WARNING: pattern '/usr/lib/os-probes/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/os-probes/mounted/20macosx'
substituteStream(): WARNING: pattern '/usr/lib/linux-boot-probes/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/os-probes/mounted/20macosx'
substituteStream(): WARNING: pattern '/usr/lib/os-prober/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/os-probes/mounted/20macosx'
substituteStream(): WARNING: pattern '/usr/lib/os-probes/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/os-probes/mounted/70hurd'
substituteStream(): WARNING: pattern '/usr/lib/linux-boot-probes/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/os-probes/mounted/70hurd'
substituteStream(): WARNING: pattern '/usr/lib/os-prober/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/os-probes/mounted/70hurd'
substituteStream(): WARNING: pattern '/usr/lib/os-probes/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/os-probes/mounted/90solaris'
substituteStream(): WARNING: pattern '/usr/lib/linux-boot-probes/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/os-probes/mounted/90solaris'
substituteStream(): WARNING: pattern '/usr/lib/os-prober/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/os-probes/mounted/90solaris'
substituteStream(): WARNING: pattern '/usr/lib/os-probes/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/os-probes/mounted/83haiku'
substituteStream(): WARNING: pattern '/usr/lib/linux-boot-probes/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/os-probes/mounted/83haiku'
substituteStream(): WARNING: pattern '/usr/lib/os-prober/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/os-probes/mounted/83haiku'
substituteStream(): WARNING: pattern '/usr/lib/os-probes/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/os-probes/mounted/10qnx'
substituteStream(): WARNING: pattern '/usr/lib/linux-boot-probes/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/os-probes/mounted/10qnx'
substituteStream(): WARNING: pattern '/usr/lib/os-prober/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/os-probes/mounted/10qnx'
substituteStream(): WARNING: pattern '/usr/lib/os-probes/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/os-probes/mounted/20microsoft'
substituteStream(): WARNING: pattern '/usr/lib/linux-boot-probes/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/os-probes/mounted/20microsoft'
substituteStream(): WARNING: pattern '/usr/lib/os-prober/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/os-probes/mounted/20microsoft'
substituteStream(): WARNING: pattern '/usr/lib/os-probes/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/os-probes/mounted/10freedos'
substituteStream(): WARNING: pattern '/usr/lib/linux-boot-probes/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/os-probes/mounted/10freedos'
substituteStream(): WARNING: pattern '/usr/lib/os-prober/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/os-probes/mounted/10freedos'
substituteStream(): WARNING: pattern '/usr/lib/os-probes/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/os-probes/mounted/40lsb'
substituteStream(): WARNING: pattern '/usr/lib/linux-boot-probes/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/os-probes/mounted/40lsb'
substituteStream(): WARNING: pattern '/usr/lib/os-prober/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/os-probes/mounted/40lsb'
substituteStream(): WARNING: pattern '/usr/lib/os-probes/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/os-probes/mounted/efi/10elilo'
substituteStream(): WARNING: pattern '/usr/lib/linux-boot-probes/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/os-probes/mounted/efi/10elilo'
substituteStream(): WARNING: pattern '/usr/lib/os-prober/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/os-probes/mounted/efi/10elilo'
substituteStream(): WARNING: pattern '/usr/lib/os-probes/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/os-probes/mounted/efi/20microsoft'
substituteStream(): WARNING: pattern '/usr/lib/linux-boot-probes/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/os-probes/mounted/efi/20microsoft'
substituteStream(): WARNING: pattern '/usr/lib/os-prober/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/os-probes/mounted/efi/20microsoft'
substituteStream(): WARNING: pattern '/usr/lib/linux-boot-probes/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/os-probes/50mounted-tests'
substituteStream(): WARNING: pattern '/usr/lib/os-prober/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/os-probes/50mounted-tests'
substituteStream(): WARNING: pattern '/usr/share/os-prober/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/os-probes/init/10filesystems'
substituteStream(): WARNING: pattern '/usr/lib/os-probes/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/os-probes/init/10filesystems'
substituteStream(): WARNING: pattern '/usr/lib/linux-boot-probes/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/os-probes/init/10filesystems'
substituteStream(): WARNING: pattern '/usr/lib/os-prober/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/os-probes/init/10filesystems'
substituteStream(): WARNING: pattern '/usr/lib/os-probes/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/linux-boot-probes/mounted/50lilo'
substituteStream(): WARNING: pattern '/usr/lib/linux-boot-probes/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/linux-boot-probes/mounted/50lilo'
substituteStream(): WARNING: pattern '/usr/lib/os-prober/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/linux-boot-probes/mounted/50lilo'
substituteStream(): WARNING: pattern '/usr/lib/os-probes/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/linux-boot-probes/mounted/40grub'
substituteStream(): WARNING: pattern '/usr/lib/linux-boot-probes/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/linux-boot-probes/mounted/40grub'
substituteStream(): WARNING: pattern '/usr/lib/os-prober/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/linux-boot-probes/mounted/40grub'
substituteStream(): WARNING: pattern '/usr/lib/os-probes/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/linux-boot-probes/mounted/40grub2'
substituteStream(): WARNING: pattern '/usr/lib/linux-boot-probes/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/linux-boot-probes/mounted/40grub2'
substituteStream(): WARNING: pattern '/usr/lib/os-prober/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/linux-boot-probes/mounted/40grub2'
substituteStream(): WARNING: pattern '/usr/lib/os-probes/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/linux-boot-probes/mounted/90fallback'
substituteStream(): WARNING: pattern '/usr/lib/linux-boot-probes/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/linux-boot-probes/mounted/90fallback'
substituteStream(): WARNING: pattern '/usr/lib/os-prober/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/linux-boot-probes/mounted/90fallback'
substituteStream(): WARNING: pattern '/usr/lib/os-probes/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/linux-boot-probes/50mounted-tests'
substituteStream(): WARNING: pattern '/usr/lib/os-prober/' doesn't match anything in file '/nix/store/82jaanwmfnzk7ysinw06v7sacnzh0b2b-os-prober-1.77/lib/linux-boot-probes/50mounted-tests'

Please check the offending substituteInPlace for typos or changes in source.

zfs:

A substituteInPlace with an unused --replace got detected:

substituteStream(): WARNING: pattern 'zfs-import-cache.service' doesn't match anything in file '/nix/store/apwydbgrahjgxq378xrqmi7lx36s0pkm-zfs-user-2.0.1/etc/systemd/system/zfs-import.target'
substituteStream(): WARNING: pattern 'zfs-import-cache.service' doesn't match anything in file '/nix/store/apwydbgrahjgxq378xrqmi7lx36s0pkm-zfs-user-2.0.1/etc/systemd/system/zfs-mount.service'
substituteStream(): WARNING: pattern 'zfs-import-cache.service' doesn't match anything in file '/nix/store/apwydbgrahjgxq378xrqmi7lx36s0pkm-zfs-user-2.0.1/etc/systemd/system/zfs-share.service'
substituteStream(): WARNING: pattern 'zfs-import-cache.service' doesn't match anything in file '/nix/store/apwydbgrahjgxq378xrqmi7lx36s0pkm-zfs-user-2.0.1/etc/systemd/system/zfs-volume-wait.service'
substituteStream(): WARNING: pattern 'zfs-import-cache.service' doesn't match anything in file '/nix/store/apwydbgrahjgxq378xrqmi7lx36s0pkm-zfs-user-2.0.1/etc/systemd/system/zfs-volumes.target'
substituteStream(): WARNING: pattern 'zfs-import-cache.service' doesn't match anything in file '/nix/store/apwydbgrahjgxq378xrqmi7lx36s0pkm-zfs-user-2.0.1/etc/systemd/system/zfs-zed.service'
substituteStream(): WARNING: pattern 'zfs-import-cache.service' doesn't match anything in file '/nix/store/apwydbgrahjgxq378xrqmi7lx36s0pkm-zfs-user-2.0.1/etc/systemd/system/zfs.target'

Please check the offending substituteInPlace for typos or changes in source.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 109566 run on x86_64-darwin 1

3 packages marked as broken and skipped:
  • haskellPackages.libzfs
  • sanoid
  • smartmontools

@ghost
Copy link
Author

ghost commented Jan 17, 2021

Did I break this package on darwin? It's "marked as broken" not "failed to build", which implies it was broken before this PR? Some help would be appreciated, I'm confused.

@SuperSandro2000
Copy link
Member

Did I break this package on darwin?

No, it was broken before.

It's "marked as broken" not "failed to build", which implies it was broken before this PR?

Yeah, someone marked it as failing to build before.

@ghost
Copy link
Author

ghost commented Jan 17, 2021

Good to know, thanks. Guess there's no further action required from me to get this merged?

@SuperSandro2000 SuperSandro2000 merged commit 822e677 into NixOS:master Jan 17, 2021
@ghost ghost deleted the smartmontools branch January 18, 2021 01:59
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/when-to-use-substituteinplace-functions-vs-a-patch/11073/4

@raboof raboof mentioned this pull request Feb 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frostman Frostman Awaiting requested review from Frostman

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SuperSandro2000 @nixos-discourse @peti