Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graph-cli: init at 0.1.7 #109562

Merged
merged 2 commits into from Jan 19, 2021
Merged

graph-cli: init at 0.1.7 #109562

merged 2 commits into from Jan 19, 2021

Conversation

leungbk
Copy link
Member

@leungbk leungbk commented Jan 16, 2021

Motivation for this change

Add graph-cli, a Python CLI for making graphs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@leungbk leungbk force-pushed the graph-cli branch 2 times, most recently from 0ebe3b4 to 74edf3c Compare January 16, 2021 20:17
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109562 run on x86_64-darwin 1

1 package built:
  • graph-cli

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

graph-cli:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 17, 2021 •
edited

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109562 run on x86_64-linux 1

1 package built:
  • graph-cli

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

graph-cli:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.

@leungbk
Copy link
Member Author

leungbk commented Jan 17, 2021

There don't appear to be any tests; the Makefile in the GitHub repo references a nonexistent tests directory. For this reason, I've disabled doCheck and run pythonImportsCheck instead.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109562 run on x86_64-darwin 1

1 package built:
  • graph-cli

@SuperSandro2000
Copy link
Member

Please squash the last review commit into the package init commit.

leungbk and others added 2 commits January 17, 2021 16:28
@leungbk
maintainers: add leungbk
2c57433
@leungbk @SuperSandro2000
graph-cli: init at 0.1.7
dcfc3b1 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@leungbk
Copy link
Member Author

leungbk commented Jan 18, 2021

Please squash the last review commit into the package init commit.

Done.

@SuperSandro2000 SuperSandro2000 merged commit 1e5e5bd into NixOS:master Jan 19, 2021
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109562 run on x86_64-linux 11

1 package built:
  • graph-cli

@leungbk leungbk deleted the graph-cli branch January 19, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leungbk @SuperSandro2000