ocamlPackages: init xenstore, xenstore_transport, vchan, tls-mirage, conduit-mirage and cohttp-mirage #109621
Conversation
sternenseemann
force-pushed
the
cohttp-mirage-2.5.4
branch
from
70c115b
to
91a89e0
Compare
|
@GrahamcOfBorg build ocamlPackages.cohttp-mirage ocamlPackages.xenstore-tool ocaml-ng.ocamlPackages_4_08.cohttp-mirage |
| }; | ||
|
|
||
| nativeBuildInputs = [ | ||
| ppx_sexp_conv |
There was a problem hiding this comment.
This one should be propagated.
There was a problem hiding this comment.
Really? I isn't listed in the libraries field of any dune file, is it?
There was a problem hiding this comment.
Maybe not in the source, but after compilation, it ends up in the dune-package and META files.
There was a problem hiding this comment.
Alright, is fixed!
sternenseemann
force-pushed
the
cohttp-mirage-2.5.4
branch
from
91a89e0
to
d2cadd9
Compare
sternenseemann
force-pushed
the
cohttp-mirage-2.5.4
branch
from
d2cadd9
to
c3aa6c1
Compare
| sha256 = "1kxxd9i4qiq98r7sgvl59iq2ni7y6drnv48qj580q5cyiyyc85q3"; | ||
| }; | ||
|
|
||
| propagatedBuildInputs = [ xenstore lwt ]; |
There was a problem hiding this comment.
@sternenseemann this is missing a dependency on stdlib-shims
There was a problem hiding this comment.
Really? Neither in opam nor anywhere in the repository stdlib-shims is referencend.
There was a problem hiding this comment.
check this failure: https://github.com/anmonteiro/nix-overlays/runs/1786341313#step:5:1245
There was a problem hiding this comment.
oh that's actually saying xenstore requires it, not xenstore_transport.
There was a problem hiding this comment.
hmmm it could also be a dune 2 quirk. I default to dune2 for building all packages
There was a problem hiding this comment.
On master everything builds fine for me with 4.11 as well, can you reproduce it there?
There was a problem hiding this comment.
Hm, I triggered it as well now in a nixpkgs-review with OCaml 4.10. Weird.
builder for '/nix/store/5fxwkbvnmjg61dxi60dsqysxgjg6gmri-ocaml4.10.0-xenstore_transport-1.3.0.drv' failed with exit code 1; last 10 log lines:
building
File "/nix/store/1f7xs83sak49nmkkhsbkd8m2bxy1mn1z-ocaml4.10.0-xenstore-2.1.1/lib/ocaml/4.10.0/site-lib/xenstore/dune-package", line 10, characters 19-31:
10 | (requires cstruct stdlib-shims)
^^^^^^^^^^^^
Error: Library "stdlib-shims" not found.
-> required by library "xenstore" in
/nix/store/1f7xs83sak49nmkkhsbkd8m2bxy1mn1z-ocaml4.10.0-xenstore-2.1.1/lib/ocaml/4.10.0/site-lib/xenstore
Hint: try:
dune external-lib-deps --missing -p xenstore_transport -j 8 @install
There was a problem hiding this comment.
aha! should we add that as a dependency to xenstore then?
There was a problem hiding this comment.
still a little weird to me that it isn't present upstream, but dune-package seems to require it.
There was a problem hiding this comment.
I'm really confused by this because I don't get what circumstances trigger this issue. On master the following turn up no results:
grep -r "stdlib-shims" $(nix-build -A ocamlPackages.xenstore --no-out-link)
So sometimes dune-package requires stdlib-shims and sometimes it doesn't?!
Motivation for this change
Reference #23955.
Add more MirageOS packages which also are required for
git-mirage>= 3.0.0:Where the last package depends on all of the packages listed before.
We also add
xenstore-toolwhich is shipped withxenstore_transport. We could also consider putting it into top level as it is a simple cli that doesn't ship with an OCaml library of any kind.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)