Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.roombapy: init at 1.6.2-1 #109642

Merged
merged 2 commits into from Jan 17, 2021
Merged

python3Packages.roombapy: init at 1.6.2-1 #109642

merged 2 commits into from Jan 17, 2021

Conversation

justinas
Copy link
Contributor

Motivation for this change

This is a dependency of Home Assistant, namely, the iRobot Roomba integration.

I do not currently have a Roomba handy to fully test on. The utility commands work though, and Home Assistant seems to start up fine with the integration enabled.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000 SuperSandro2000 changed the title Init roombapy python3Packages.roombapy: init at 1.6.2.post1 Jan 17, 2021
@justinas
Copy link
Contributor Author

Accepted the suggestions and squashed to keep the history clean.

@fabaff
Copy link
Member

fabaff commented Jan 17, 2021

This is a Home Assistant dependency. Please run

./pkgs/servers/home-assistant/parse-requirements.py

and add the changes in an additional commit. Thanks

@justinas
Copy link
Contributor Author

This is a Home Assistant dependency. Please run

./pkgs/servers/home-assistant/parse-requirements.py

and add the changes in an additional commit. Thanks

Hi, aa395e4269140a0c8a8d4ece0a0d05a76b7b306e is the result of running parse-requirements.py.

@fabaff
Copy link
Member

fabaff commented Jan 17, 2021

Sorry, the changes to component-packages.nix are added already.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109642 run on x86_64-darwin 1

3 packages built:
  • python37Packages.roombapy
  • python38Packages.roombapy
  • python39Packages.roombapy

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

python37Packages.roombapy:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
python38Packages.roombapy:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
python39Packages.roombapy:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.

fabaff
fabaff reviewed Jan 17, 2021
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The project contains tests which are part of the GitHub source tarball.

Looks like that all test requirements are already available. How about run those which don't require network access?

pkgs/development/python-modules/roombapy/default.nix Show resolved Hide resolved
@fabaff
Copy link
Member

fabaff commented Jan 17, 2021

Result of nixpkgs-review pr 109642 run on x86_64-linux 1

3 packages built:
  • python37Packages.roombapy
  • python38Packages.roombapy
  • python39Packages.roombapy

@justinas
Copy link
Contributor Author

Switched to fetchFromGithub to include tests, excluded discovery test as it needs network.

@justinas justinas changed the title python3Packages.roombapy: init at 1.6.2.post1 python3Packages.roombapy: init at 1.6.2-1 Jan 17, 2021
@justinas
Copy link
Contributor Author

By the way, version format is different in GitHub than the one in PyPI, so I changed 1.6.2.post1 to 1.6.2-1 to be consistent.

@fabaff
Copy link
Member

fabaff commented Jan 17, 2021

Result of nixpkgs-review pr 109642 run on x86_64-linux 1

2 packages built:
  • python37Packages.roombapy
  • python38Packages.roombapy

fabaff
fabaff approved these changes Jan 17, 2021
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109642 run on x86_64-linux 1

2 packages built:
  • python37Packages.roombapy
  • python38Packages.roombapy

@SuperSandro2000 SuperSandro2000 merged commit eb0b2a0 into NixOS:master Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@fabaff fabaff fabaff approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@justinas @fabaff @SuperSandro2000