Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unixtools: use real provider name instead of inaccurate version #109600

Merged
merged 1 commit into from Jul 17, 2021
Merged

unixtools: use real provider name instead of inaccurate version #109600

merged 1 commit into from Jul 17, 2021

Conversation

holymonson
Copy link
Contributor

Motivation for this change

The version "1003.1-2008" comes from IEEE Std but is not quite accurate.
Using the provider name could give us more info in store path.

cc @matthewbauer

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@holymonson
unixtools: use real provider name instead of inaccurate version
5bfd6d4 
The version "1003.1-2008" comes from IEEE Std but is not quite accurate.
Using the provider name could give us more info in store path.
@SuperSandro2000 SuperSandro2000 added this to WIP in Staging via automation Jan 17, 2021
@stale
Copy link

stale bot commented Jul 16, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 16, 2021
@Mic92 Mic92 merged commit 8e4bb16 into NixOS:staging Jul 17, 2021
Staging automation moved this from WIP to Done Jul 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@holymonson @Mic92