This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109626 run on x86_64-darwin 1

derivation '/nix/store/s7nlycb2cf17dgw9w2rc5gzbh27jxx89-ditto-impure-darwin.drv' requested impure path '/usr/bin/ditto', but it was not in allowed-impure-host-deps

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109626 run on x86_64-darwin 1

Hmmm... I understand that from a bootstrap perspective, "sudo" would need to be owned by uid 0 and have the setuid bit set to do anything useful.

Would people be opposed to add a 2nd alias to all-packages.nix that still makes it available for darwin?
(Just to make sure it still compiles, or if people want to manually set the right permissions or other horrible things)

Not sure if there's any precedence for that.

IMO we should just revert the change to pkgs/top-level/all-packages.nix and keep impure stuff in darwin.sudo

I'm not sure about this, overall. Packages in Nixpksg for NixOS and Linux don't get any setuid, why would we have impure packages for this on darwin?

@grahamc Well, to be fair, this doesn't (and can't) create any suid files in the store, only a symlink. We could consider this as a fine-grained alternative to export PATH=/usr/bin.