Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: bb3e0885d90d
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 145cf67bbbe7
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Jan 16, 2021

  1. libvirt: correct localstatedir (#109415)

    It was supposed to be '/var' rather than '/var/lib'. This fixes an issue
    where some tools don't connect to the right socket (because they were
    connecting to '$localstatedir/run/libvirt...' instead of
    '$runstatedir/libvirt...').
    
    Also change runstatedir to just be '/run' since it avoids a log line
    complaining about that.
    euank authored Jan 16, 2021

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    145cf67 View commit details
Showing with 2 additions and 2 deletions.
  1. +2 −2 pkgs/development/libraries/libvirt/default.nix
4 changes: 2 additions & 2 deletions pkgs/development/libraries/libvirt/default.nix
Original file line number Diff line number Diff line change
@@ -88,8 +88,8 @@ in stdenv.mkDerivation rec {
in [
"--sysconfdir=/var/lib"
"-Dinstall_prefix=${placeholder "out"}"
"-Dlocalstatedir=/var/lib"
"-Drunstatedir=/var/run"
"-Dlocalstatedir=/var"
"-Drunstatedir=/run"
"-Dlibpcap=enabled"
"-Ddriver_qemu=enabled"
"-Ddriver_vmware=enabled"