wasmtime: 0.21.0 -> 0.32.1 #109571
wasmtime: 0.21.0 -> 0.32.1 #109571
Conversation
|
@GrahamcOfBorg build wasmtime |
|
|
||
| nativeBuildInputs = [ python cmake clang ]; | ||
| buildInputs = [ llvmPackages.libclang ] ++ | ||
| lib.optionals stdenv.isDarwin [ darwin.apple_sdk.frameworks.Security ]; | ||
| LIBCLANG_PATH = "${llvmPackages.libclang}/lib"; | ||
|
|
||
| doCheck = true; | ||
| doCheck = false; |
There was a problem hiding this comment.
Why did you disable tests?
There was a problem hiding this comment.
Because, sadly, the test traps::parse_dwarf_info is failing (see 7e8cc4f). I didn't come around analysing it yet.
There was a problem hiding this comment.
Here is a more verbose output (captured from my Mac, testing today's dev version of wasmtime):
---- traps::parse_dwarf_info stdout ----
thread 'traps::parse_dwarf_info' panicked at 'rustc failed: exit code: 1
error[E0463]: can't find crate for `std`
|
= note: the `wasm32-wasi` target may not be installed
error: aborting due to previous error
For more information about this error, try `rustc --explain E0463`.
', tests/all/traps.rs:511:5
There was a problem hiding this comment.
Can you add that as a comment?
| buildInputs = [ llvmPackages.libclang ] ++ | ||
| lib.optionals stdenv.isDarwin [ darwin.apple_sdk.frameworks.Security ]; |
There was a problem hiding this comment.
| buildInputs = [ llvmPackages.libclang ] ++ | |
| lib.optionals stdenv.isDarwin [ darwin.apple_sdk.frameworks.Security ]; | |
| buildInputs = [ llvmPackages.libclang ] | |
| ++ lib.optionals stdenv.isDarwin [ Security ]; |
Please inherit this in top-level and add it as an input.
There was a problem hiding this comment.
Hmm, any good reason why exposing the Security framework on the top level is beneficial? After all it is only needed on Darwin (and once), not unconditionally. When grep-ping through the sources, I see all three styles (and this file was not originally written by me). I have checked in a compromise 1fb2969, which is using with and shortens the list, while opening the frameworks only in the Darwin case.
There was a problem hiding this comment.
When grep-ping through the sources
That usually include a lot of old packages which should be changed, too.
Hmm, any good reason why exposing the Security framework on the top level is beneficial?
I don't know the reason right now but darwin like pkgs shouldn't be in inputs. Using with does not solve that.
|
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 1 package built:
|
ofborg
bot
added
the
2.status: merge conflict
ofborg
bot
removed
the
2.status: merge conflict
|
Result of 1 package failed to build:
|
risicle
added
the
1.severity: security
|
https://nvd.nist.gov/vuln/detail/CVE-2021-39219 and https://nvd.nist.gov/vuln/detail/CVE-2021-39216 make this suddenly more pressing |
|
Result of 1 package failed to build:
|
|
|
In case anyone's coming up dry figuring out what
|
|
Bumping straight to 0.30.0 (like we essentially have to anyway) successfully builds for me on linux, but the Looks like something Edit: appears that |
|
Also seems that versions prior to 0.27.0 are vulnerable to https://nvd.nist.gov/vuln/detail/CVE-2021-32629 |
|
The futimens api it seems is only available on macos 10.13 or newer it seems. |
|
@GrahamcOfBorg build wasmtime |
|
|
Seems like a dependency tries to download stuff |
this is supposed to improve testing frobbed from dfinity/motoko#3041
|
|
||
| nativeBuildInputs = [ python cmake clang ]; | ||
| buildInputs = [ llvmPackages.libclang ] ++ | ||
| lib.optionals stdenv.isDarwin [ darwin.apple_sdk.frameworks.Security ]; | ||
| LIBCLANG_PATH = "${llvmPackages.libclang.lib}/lib"; | ||
|
|
||
| configurePhase = '' |
There was a problem hiding this comment.
This should likely be preConfigure. If you want to skip configurePhase use dontConfigure instead.
|
This build is not hermetic, this is why it's failing. The issue comes from I have tried to apply this patch on top of this expression. Now the problem is that the Is there a way in which I can use a specific I disregard the option of bumping nixpkgs/pkgs/development/tools/build-managers/gn/default.nix Lines 4 to 5 in e01c412 |
|
More information, it's the |
|
@ggreif: you can cherry-pick this commit on top of this PR: 60e1a92 Instead of disabling tests, I expose an environment variable to specify where the V8 archive is, so that |
|
Result: |
|
@ereslibre do you want to make a separate pull request with your working build ? (I'd be happy to help you get it merged). |
|
@happysalada I was thinking in doing so and bumping to the latest available version but I wanted to give some room for this PR to be merged since it was already open. I will open the one superseding this one at the end of my day. Thank you! |
|
Closing as #166965 merged. |
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)