Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport] zoom-us: 5.3.469451.0927 -> 5.4.53350.1027 #109612

Merged
merged 3 commits into from Jan 18, 2021
Merged

[backport] zoom-us: 5.3.469451.0927 -> 5.4.53350.1027 #109612

merged 3 commits into from Jan 18, 2021

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jan 17, 2021 •
edited

(cherry picked from commit ca6dc68)

Motivation for this change

I have not tested the backport. I only tested wether it builds.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

emptyflask and others added 3 commits January 17, 2021 10:01
@emptyflask @Mic92
zoom-us: 5.3.469451.0927 -> 5.4.53350.1027
722f956 
(cherry picked from commit ca6dc68)
@Mic92
zoom-us: support alsa
f9439f1 
(cherry picked from commit d352152)
@Mic92
zoom-us: 5.4.53350.1027 -> 5.4.57862.0110
14d7bfa 
Replacing zooms qt library has led to incompatibilities between
qt versions used in Nix and zoom. The new approach just sets
LD_LIBRARY_PATH. LD_LIBRARY_PATH is also used internally by zoom
for its own vendored library.

The package has been tested end-to-end in a meeting.

(cherry picked from commit 0c4d956)
@Mic92 Mic92 changed the title zoom-us: 5.3.469451.0927 -> 5.4.53350.1027 [backport] zoom-us: 5.3.469451.0927 -> 5.4.53350.1027 Jan 17, 2021
@Mic92 Mic92 mentioned this pull request Jan 17, 2021
Merged
10 tasks
@hmenke
Copy link
Member

hmenke commented Jan 17, 2021

Result of nixpkgs-review pr 109612 1

1 package built:
  • zoom-us

hmenke
hmenke approved these changes Jan 17, 2021
View reviewed changes
Copy link
Member

@hmenke hmenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It launches and I can start meetings.

@Mic92 Mic92 merged commit 88f00e7 into NixOS:release-20.09 Jan 18, 2021
@Mic92 Mic92 deleted the zoom-backport branch January 18, 2021 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmenke hmenke hmenke approved these changes

@danbst danbst Awaiting requested review from danbst

@doronbehar doronbehar Awaiting requested review from doronbehar

@tadfisher tadfisher Awaiting requested review from tadfisher

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @hmenke @emptyflask