Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mediawiki: 1.35.0 -> 1.35.1 #109584

Merged
merged 1 commit into from Jan 17, 2021
Merged

mediawiki: 1.35.0 -> 1.35.1 #109584

merged 1 commit into from Jan 17, 2021

Conversation

LeSuisse
Copy link
Contributor

Motivation for this change

Main goal is to pull the security fixes for:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from redvers January 16, 2021 23:21
@prusnak prusnak added the 9.needs: port to stable A PR needs a backport to the stable release. label Jan 16, 2021
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109584 run on x86_64-linux 1

1 package blacklisted:
  • tests.nixos-functions.nixos-test
1 package built:
  • mediawiki

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109584 run on x86_64-darwin 1

1 package built:
  • mediawiki

@SuperSandro2000 SuperSandro2000 merged commit a303f9f into NixOS:master Jan 17, 2021
@LeSuisse LeSuisse deleted the mediawiki-1.35.1 branch January 18, 2021 08:10
@LeSuisse LeSuisse mentioned this pull request Jan 19, 2021
Closed
11 tasks
@erictapen
Copy link
Member

Backporting all these CVEs might be some work.
@redvers wdyt, can we safely upgrade 1.34.4 -> 1.35.1 on stable?

@dotlambda
Copy link
Member

I just went ahead and backported the update: #111550
I don't know if it contains any breaking changes.

@TredwellGit TredwellGit added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redvers redvers Awaiting requested review from redvers

Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@LeSuisse @SuperSandro2000 @erictapen @dotlambda @prusnak @TredwellGit