Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metapixel: init at 1.0.2 #109567

Merged
merged 1 commit into from Jan 17, 2021
Merged

metapixel: init at 1.0.2 #109567

merged 1 commit into from Jan 17, 2021

Conversation

dali99
Copy link
Member

@dali99 dali99 commented Jan 16, 2021

Motivation for this change

I needed this program, and though it is a little old it is working and available in many other distros:
https://repology.org/project/metapixel/versions

Things done

Package installs, but the manual page is not compiled. The Makefile wants to read a docbook from some path in /usr/lib and I don't know enough about how manuals are supposed work to fix that.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109567 run on x86_64-linux 1

1 package built:
  • metapixel

prusnak
prusnak requested changes Jan 17, 2021
View reviewed changes
pkgs/tools/graphics/metapixel/default.nix Outdated Show resolved Hide resolved
pkgs/tools/graphics/metapixel/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109567 run on x86_64-linux 1

1 package built:
  • metapixel

@SuperSandro2000 SuperSandro2000 merged commit e53c43b into NixOS:master Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak Awaiting requested review from prusnak

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dali99 @SuperSandro2000 @prusnak