Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sqlar: fix build error #109579

Merged
merged 1 commit into from Jan 17, 2021
Merged

sqlar: fix build error #109579

merged 1 commit into from Jan 17, 2021

Conversation

nagy
Copy link
Member

@nagy nagy commented Jan 16, 2021

Motivation for this change

This fixes the broken sqlar package. This is the broken build:
https://hydra.nixos.org/build/134856172

This is probably a regression from the recent gcc 10 bump.

cc @dtzWill

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nagy
sqlar: fix build error
531e121 
Disable warnings to be treated as errors, since otherwise the build
would fail with this message:

```
sqlite3.c: In function 'sqlite3SelectNew':
sqlite3.c:116663:10: error: function may return address of local variable [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wreturn-local-addr-Werror=return-local-addr8;;]
116663 |   return pNew;
```
@ofborg ofborg bot requested a review from dtzWill January 16, 2021 22:54
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109579 run on x86_64-linux 1

1 package built:
  • sqlar

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 109579 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • sqlar

@SuperSandro2000 SuperSandro2000 merged commit fbd7615 into NixOS:master Jan 17, 2021
@nagy nagy deleted the sqlar-fix branch January 17, 2021 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzWill dtzWill Awaiting requested review from dtzWill

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nagy @SuperSandro2000