Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkgs/development/{node-packages,web}: stdenv.lib -> lib #109656

Closed
wants to merge 2 commits into from
Closed

pkgs/development/{node-packages,web}: stdenv.lib -> lib #109656

wants to merge 2 commits into from

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Jan 17, 2021

Motivation for this change

Part of #108938

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@prusnak prusnak changed the title pkgs/development/node-packages: stdenv.lib -> lib pkgs/development/{node-packages,web}: stdenv.lib -> lib Jan 17, 2021
SuperSandro2000
SuperSandro2000 reviewed Jan 17, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is any of those files generated by node2nix?

@prusnak
Copy link
Member Author

prusnak commented Jan 17, 2021 •
edited

Is any of those files generated by node2nix?

Some of them yes. But I tried to reproduce the changes the same way they were introduced in svanderburg/node2nix#224

@SuperSandro2000
Copy link
Member

Some of them yes. But I tried to reproduce the changes the same way they were introduced in svanderburg/node2nix#224

Would it be feasible to track that patch if it takes upstream a while to merge it?

@prusnak
Copy link
Member Author

prusnak commented Jan 17, 2021

I will close this PR for now. We can reopen/rebase this later if still needed.

@prusnak prusnak closed this Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prusnak @SuperSandro2000