Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alsaLib: correct license field #109596

Merged
merged 1 commit into from Jan 17, 2021
Merged

alsaLib: correct license field #109596

merged 1 commit into from Jan 17, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jan 17, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff
Copy link
Member

fabaff commented Jan 17, 2021

Could you please update the commit message acc. the CONTRIBUTING.md details?

alsa-lib: correct license field

fabaff
fabaff approved these changes Jan 17, 2021
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reference: https://github.com/alsa-project/alsa-lib/blob/master/src/rawmidi/rawmidi.c#L13-L15

Looks good to me.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 17, 2021 •
edited

But there license file seems to be lgpl21Only https://github.com/alsa-project/alsa-lib/blob/master/COPYING

I am confused.

@fabaff
Copy link
Member

fabaff commented Jan 17, 2021

But there license file seems to be lgpl21Only https://github.com/alsa-project/alsa-lib/blob/master/COPYING

COPYING contains the original content of the license (LGPLv2.1). Paragraph 13 of the license describes the usage of "any later version". Upstream is clarifying it in their file headers that later versions of the LGPLv2.1 are supported. Thus from my point of view LGPLv2.1+ is correct.

Is in sync with other distributions:

@ghost
Copy link
Author

ghost commented Jan 17, 2021

Could you please update the commit message acc. the CONTRIBUTING.md details?

alsa-lib: correct license field

I think my formatting is correct. At least it's the same as all of the previous edits of that file:

screenshot2

@SuperSandro2000 SuperSandro2000 merged commit 77edbd6 into NixOS:master Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fabaff @SuperSandro2000