Codechange: [Win32] Window driver cleanup #8586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Functional it is identical. Just helps future-us when searching for sleeps.
Other drivers do this too, and this makes the world a bit more the same.
Sometimes it returned an usererror(), sometimes Start() failed. Now it always fails on Start(), so nothing else has to check again what blitter is used. AfterBlitterChange() can never change to a 0bpp, so it is sufficient to guard this with an assert().
LordAro
approved these changes
Jan 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem / Description
The different video drivers do similar things differently.
Make the Win32 driver more similar to the other drivers. While at it, fix some things like outdated comments or unneeded work-arounds for Windows 95.
This is not supposed to change any functionality.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.
This PR affects the save game format? (label 'savegame upgrade')This PR affects the GS/AI API? (label 'needs review: Script API')ai_changelog.hpp, gs_changelog.hpp need updating.The compatibility wrappers (compat_*.nut) need updating.This PR affects the NewGRF API? (label 'needs review: NewGRF')newgrf_debug_data.h may need updating.PR must be added to API tracker