Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

facet search update item hover interaction #263

Merged
merged 3 commits into from Jan 17, 2021
Merged

facet search update item hover interaction #263

merged 3 commits into from Jan 17, 2021

Conversation

turboMaCk
Copy link
Member

This partially reverts the change I made in #262 - the hover action on whole result item. Now the underline hover applies only on new clickable area (button itself).

image

update-hover

@turboMaCk turboMaCk requested a review from garbas January 17, 2021 09:50
@turboMaCk turboMaCk self-assigned this Jan 17, 2021
@turboMaCk turboMaCk mentioned this pull request Jan 17, 2021
Merged
@github-actions
Copy link
Contributor

🚀 Deployed on https://600408b5685d268fadd725de--nixos-search.netlify.app

@turboMaCk turboMaCk changed the base branch from main to faceted-search January 17, 2021 09:52
@turboMaCk turboMaCk changed the title Turbo ma ck/facet search item hover facet search update item hover interaction Jan 17, 2021
@turboMaCk turboMaCk mentioned this pull request Jan 17, 2021
Merged
@turboMaCk turboMaCk linked an issue Jan 17, 2021 that may be closed by this pull request
faceted search for packages #163
Closed
@turboMaCk turboMaCk marked this pull request as draft January 17, 2021 15:18
@turboMaCk turboMaCk marked this pull request as ready for review January 17, 2021 15:19
@turboMaCk
Copy link
Member Author

@garbas conflict resolved & tested.

@github-actions
Copy link
Contributor

🚀 Deployed on https://600455e2511639382fe7b513--nixos-search.netlify.app

@garbas
Copy link
Member

garbas commented Jan 17, 2021

🥇

@garbas garbas merged commit c909f6f into faceted-search Jan 17, 2021
@garbas garbas deleted the turboMaCk/facet-search-item-hover branch January 17, 2021 15:22
@garbas
Copy link
Member

garbas commented Jan 17, 2021 •
edited

@turboMaCk since I see you are online. want to pair and work further on this? if yes join marketing irc channel and ping me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garbas garbas garbas approved these changes

Assignees

@turboMaCk turboMaCk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

faceted search for packages
2 participants
@turboMaCk @garbas