Skip to content

pkgs/development: stdenv.lib -> lib #109648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2021
Merged

pkgs/development: stdenv.lib -> lib #109648

merged 1 commit into from
Jan 17, 2021
+57 −59

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Jan 17, 2021 •
edited
Loading

Part of #108938

I inspected files in pkgs/development and took care of folders with 10 or less replacements needed. Others will follow in separate pull requests.

this takes care of the following folders in pkgs/development:

  • arduino
  • chez-modules
  • go-packages
  • guile-modules
  • idris-modules
  • perl-modules
  • r-modules
  • ruby-modules
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@prusnak prusnak mentioned this pull request Jan 17, 2021
Closed
siraben
siraben approved these changes Jan 17, 2021
View reviewed changes
Copy link
Member

@siraben siraben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ofborg ofborg bot added the 6.topic: ruby label Jan 17, 2021
@sternenseemann
Copy link
Member

Eval failure in androidndk-pkgs: https://gist.github.com/GrahamcOfBorg/27a98d4fdb81bfb21ce9936987df603d

@prusnak
Copy link
Member Author

prusnak commented Jan 17, 2021

Eval failure in androidndk-pkgs: https://gist.github.com/GrahamcOfBorg/27a98d4fdb81bfb21ce9936987df603d

Hopefully addressed correctly in 33ab5be25589f1a276078ab203d76b7ee3bc2b08

@prusnak
Copy link
Member Author

prusnak commented Jan 17, 2021

Hm, not sure how to fix androidndk-pkgs, dropping from the PR

@prusnak
pkgs/development: stdenv.lib -> lib

Verified

This commit was signed with the committer’s verified signature.
prusnak Pavol Rusnak
GPG key ID: 91F3B339B9A02A3D
Verified
Learn about vigilant mode
cf2a67f 
this takes care of the following folders in pkgs/development:
* arduino
* chez-modules
* go-packages
* guile-modules
* idris-modules
* perl-modules
* r-modules
* ruby-modules
@prusnak
Copy link
Member Author

prusnak commented Jan 17, 2021

Removing also java-modules from the PR (my Java kung-fu is not that strong).

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 17, 2021
@SuperSandro2000 SuperSandro2000 merged commit 628900c into NixOS:master Jan 17, 2021
@prusnak prusnak deleted the stdenv-lib branch January 17, 2021 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sternenseemann sternenseemann

@SuperSandro2000 SuperSandro2000

@siraben siraben

@alyssais alyssais

@infinisil infinisil

@kalbasit kalbasit

@Mic92 Mic92

@peti peti

@stigtsp stigtsp

@zowoq zowoq

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@prusnak @sternenseemann @SuperSandro2000 @siraben