Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

home-assistant: 2021.1.3 -> 2021.1.4 (+zigpy) #109605

Merged
merged 2 commits into from Jan 17, 2021

Conversation

mweinelt
Copy link
Member

Motivation for this change

https://github.com/home-assistant/core/releases/tag/2021.1.4

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt mweinelt changed the title Home assistant home-assistant: 2021.1.3 -> 2021.1.4 Jan 17, 2021
@mweinelt mweinelt changed the title home-assistant: 2021.1.3 -> 2021.1.4 home-assistant: 2021.1.3 -> 2021.1.4 (+zigpy) Jan 17, 2021
@ofborg ofborg bot requested review from etu, dotlambda, Mic92 and globin January 17, 2021 08:42
@fabaff
Copy link
Member

fabaff commented Jan 17, 2021

Result of nixpkgs-review pr 109605 run on x86_64-linux 1

22 packages built:
  • home-assistant
  • python37Packages.bellows
  • python37Packages.zha-quirks
  • python37Packages.zigpy
  • python37Packages.zigpy-deconz
  • python37Packages.zigpy-znp
  • python38Packages.bellows
  • python38Packages.zha-quirks
  • python38Packages.zigpy
  • python38Packages.zigpy-cc
  • python38Packages.zigpy-deconz
  • python38Packages.zigpy-xbee
  • python38Packages.zigpy-zigate
  • python38Packages.zigpy-znp
  • python39Packages.bellows
  • python39Packages.zha-quirks
  • python39Packages.zigpy
  • python39Packages.zigpy-cc
  • python39Packages.zigpy-deconz
  • python39Packages.zigpy-xbee
  • python39Packages.zigpy-zigate
  • python39Packages.zigpy-znp

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mweinelt
Copy link
Member Author

mweinelt commented Jan 17, 2021

x86_64 seems to run into a spurious test failure:

==================================== ERRORS ====================================
_______________ ERROR at setup of test_remove_older_logs[pyloop] _______________
[gw6] linux -- Python 3.8.6 /nix/store/yi9a1fafijn0nf5m8qkmnl955vi2mncm-python3-3.8.6/bin/python3.8
loop_factory = <class 'asyncio.unix_events._UnixDefaultEventLoopPolicy'>
fast = False, loop_debug = False
    @pytest.fixture
    def loop(loop_factory, fast, loop_debug):  # type: ignore
        """Return an instance of the event loop."""
        policy = loop_factory()
        asyncio.set_event_loop_policy(policy)
>       with loop_context(fast=fast) as _loop:

/nix/store/6ij587xhxfxngkx8d0brwgbhxv2ai1pj-python3.8-aiohttp-3.7.3/lib/python3.8/site-packages/aiohttp/pytest_plugin.py:228:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
/nix/store/yi9a1fafijn0nf5m8qkmnl955vi2mncm-python3-3.8.6/lib/python3.8/contextlib.py:113: in __enter__
    return next(self.gen)
/nix/store/6ij587xhxfxngkx8d0brwgbhxv2ai1pj-python3.8-aiohttp-3.7.3/lib/python3.8/site-packages/aiohttp/test_utils.py:493: in loop_context
    loop = setup_test_loop(loop_factory)
/nix/store/6ij587xhxfxngkx8d0brwgbhxv2ai1pj-python3.8-aiohttp-3.7.3/lib/python3.8/site-packages/aiohttp/test_utils.py:514: in setup_test_loop
    asyncio.set_event_loop(loop)
/nix/store/yi9a1fafijn0nf5m8qkmnl955vi2mncm-python3-3.8.6/lib/python3.8/asyncio/events.py:753: in set_event_loop
    get_event_loop_policy().set_event_loop(loop)
/nix/store/yi9a1fafijn0nf5m8qkmnl955vi2mncm-python3-3.8.6/lib/python3.8/asyncio/unix_events.py:1365: in set_event_loop
    self._watcher.attach_loop(loop)
/nix/store/yi9a1fafijn0nf5m8qkmnl955vi2mncm-python3-3.8.6/lib/python3.8/asyncio/unix_events.py:931: in attach_loop
    self._do_waitpid_all()
/nix/store/yi9a1fafijn0nf5m8qkmnl955vi2mncm-python3-3.8.6/lib/python3.8/asyncio/unix_events.py:985: in _do_waitpid_all
    self._do_waitpid(pid)
/nix/store/yi9a1fafijn0nf5m8qkmnl955vi2mncm-python3-3.8.6/lib/python3.8/asyncio/unix_events.py:1019: in _do_waitpid
    callback(pid, returncode, *args)
/nix/store/yi9a1fafijn0nf5m8qkmnl955vi2mncm-python3-3.8.6/lib/python3.8/asyncio/unix_events.py:216: in _child_watcher_callback
    self.call_soon_threadsafe(transp._process_exited, returncode)
/nix/store/yi9a1fafijn0nf5m8qkmnl955vi2mncm-python3-3.8.6/lib/python3.8/asyncio/base_events.py:764: in call_soon_threadsafe
    self._check_closed()
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
self = <_UnixSelectorEventLoop running=False closed=True debug=False>
    def _check_closed(self):
        if self._closed:
>           raise RuntimeError('Event loop is closed')
E           RuntimeError: Event loop is closed

/nix/store/yi9a1fafijn0nf5m8qkmnl955vi2mncm-python3-3.8.6/lib/python3.8/asyncio/base_events.py:508: RuntimeError

@mweinelt
Copy link
Member Author

mweinelt commented Jan 17, 2021

Sadly unable to reproduce locally.

@GrahamcOfBorg test home-assistant

@mweinelt
Copy link
Member Author

Disabled the test case, as it just seems to be racy.

@mweinelt mweinelt merged commit 0734f95 into NixOS:master Jan 17, 2021
@mweinelt mweinelt deleted the home-assistant branch January 17, 2021 10:15
Copy link
Contributor

@etu etu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine, just built it on my local setup with both Z-Wave and Zigbee devices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants