Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

starspace: init at 8aee0a950aa607c023e5c91cff518bec335b5df5 #109651

Merged
merged 1 commit into from Jan 17, 2021
Merged

starspace: init at 8aee0a950aa607c023e5c91cff518bec335b5df5 #109651

merged 1 commit into from Jan 17, 2021

Conversation

mausch
Copy link
Member

@mausch mausch commented Jan 17, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

prusnak
prusnak reviewed Jan 17, 2021
View reviewed changes
pkgs/applications/science/machine-learning/starspace/default.nix Outdated
sha256 = "0sc7a37z1skb9377a1qs8ggwrkz0nmpybx7sms38xj05b702kbvj";
};

nativeBuildInputs = [ boost165 ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like to belong rather to buildInputs.

Also are you use newer boost cannot be used? If yes, please provide a comment describing the issue when building with newer boost (i.e. boost package).

Copy link
Member Author

@mausch mausch Jan 17, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like to belong rather to buildInputs.

Applied in f8b69fa

Also are you use newer boost cannot be used?

The documentation for StarSpace explicitly mentions Boost 1.63, which was deleted from nixpkgs some time ago. So I used 1.65 which seems to work.
No idea if if works with a newer version but why would we want to deviate so much from the official requirements?

@prusnak prusnak merged commit 3f5d6b2 into NixOS:master Jan 17, 2021
@mausch
Copy link
Member Author

mausch commented Jan 17, 2021

Thank you for the reviews @prusnak @fabaff 👍

@mausch mausch deleted the starspace branch February 21, 2021 17:44
@mausch mausch mentioned this pull request Jun 15, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabaff fabaff fabaff left review comments

@prusnak prusnak prusnak approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mausch @prusnak @fabaff