Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fcitx5 #109649

Merged
merged 4 commits into from Jan 19, 2021
Merged

Fix fcitx5 #109649

merged 4 commits into from Jan 19, 2021

Conversation

berberman
Copy link
Member

Motivation for this change

Closes #109631

This PR fixes two bugs in fcitx5 packaging:

  • libfcitx5platforminputcontextplugin.so was not captured, resulting in missing input method module for Qt5
  • .desktop files pointed to unwrapped executables before symlinkJoin, leading to failure of addons
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @poscat0x04

@ofborg ofborg bot requested a review from poscat0x04 January 17, 2021 17:22
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109649 run on x86_64-linux 1

1 package failed to build and are new build failure:
5 packages built:
  • fcitx5-configtool
  • fcitx5-with-addons
  • libsForQt5.fcitx5-qt (libsForQt515.fcitx5-qt)
  • libsForQt512.fcitx5-qt
  • libsForQt514.fcitx5-qt

poscat0x04
poscat0x04 approved these changes Jan 18, 2021
View reviewed changes
Copy link
Contributor

@poscat0x04 poscat0x04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkgs/tools/inputmethods/fcitx5/fcitx5-qt.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot requested a review from poscat0x04 January 18, 2021 02:30
@berberman
Copy link
Member Author

1 package failed to build and are new build failure:

@SuperSandro2000 I could not reproduce this error on my machine.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109649 run on x86_64-linux 1

6 packages built:
  • fcitx5-chinese-addons
  • fcitx5-configtool
  • fcitx5-with-addons
  • libsForQt5.fcitx5-qt (libsForQt515.fcitx5-qt)
  • libsForQt512.fcitx5-qt
  • libsForQt514.fcitx5-qt

@SuperSandro2000
Copy link
Member

Please remove the master merge commit. Then we can merge this.

@berberman
Copy link
Member Author

ping @SuperSandro2000

@SuperSandro2000
Copy link
Member

@ofborg eval

@SuperSandro2000
Copy link
Member

@ofborg eval

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109649 run on x86_64-linux 1

6 packages built:
  • fcitx5-chinese-addons
  • fcitx5-configtool
  • fcitx5-with-addons
  • libsForQt5.fcitx5-qt (libsForQt515.fcitx5-qt ,plasma5Packages.fcitx5-qt)
  • libsForQt512.fcitx5-qt
  • libsForQt514.fcitx5-qt

@SuperSandro2000 SuperSandro2000 merged commit 337b3f9 into NixOS:master Jan 19, 2021
@berberman berberman deleted the fix-fcitx5 branch January 19, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poscat0x04 poscat0x04 Awaiting requested review from poscat0x04

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fctix5 does not work in qt programs
4 participants
@berberman @SuperSandro2000 @poscat0x04 @Janik-Haag